Commit 61c32102 authored by Alan Tull's avatar Alan Tull Committed by Greg Kroah-Hartman

fpga: region: use image info as parameter for programming region

Use FPGA image info (region->info) when region code is
programming the FPGA to pass in multiple parameters.

This is a baby step in refactoring the FPGA region code to
separate out common FPGA region code from FPGA region
Device Tree overlay support.
Signed-off-by: default avatarAlan Tull <atull@kernel.org>
Acked-by: default avatarMoritz Fischer <mdf@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed81f5fc
...@@ -223,14 +223,13 @@ static int fpga_region_get_bridges(struct fpga_region *region, ...@@ -223,14 +223,13 @@ static int fpga_region_get_bridges(struct fpga_region *region,
/** /**
* fpga_region_program_fpga - program FPGA * fpga_region_program_fpga - program FPGA
* @region: FPGA region * @region: FPGA region
* @overlay: device node of the overlay * Program an FPGA using fpga image info (region->info).
* Program an FPGA using information in the region's fpga image info.
* Return 0 for success or negative error code. * Return 0 for success or negative error code.
*/ */
static int fpga_region_program_fpga(struct fpga_region *region, static int fpga_region_program_fpga(struct fpga_region *region)
struct device_node *overlay)
{ {
struct device *dev = &region->dev; struct device *dev = &region->dev;
struct fpga_image_info *info = region->info;
int ret; int ret;
region = fpga_region_get(region); region = fpga_region_get(region);
...@@ -245,7 +244,7 @@ static int fpga_region_program_fpga(struct fpga_region *region, ...@@ -245,7 +244,7 @@ static int fpga_region_program_fpga(struct fpga_region *region,
goto err_put_region; goto err_put_region;
} }
ret = fpga_region_get_bridges(region, overlay); ret = fpga_region_get_bridges(region, info->overlay);
if (ret) { if (ret) {
dev_err(dev, "failed to get FPGA bridges\n"); dev_err(dev, "failed to get FPGA bridges\n");
goto err_unlock_mgr; goto err_unlock_mgr;
...@@ -257,7 +256,7 @@ static int fpga_region_program_fpga(struct fpga_region *region, ...@@ -257,7 +256,7 @@ static int fpga_region_program_fpga(struct fpga_region *region,
goto err_put_br; goto err_put_br;
} }
ret = fpga_mgr_load(region->mgr, region->info); ret = fpga_mgr_load(region->mgr, info);
if (ret) { if (ret) {
dev_err(dev, "failed to load FPGA image\n"); dev_err(dev, "failed to load FPGA image\n");
goto err_put_br; goto err_put_br;
...@@ -373,6 +372,8 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region, ...@@ -373,6 +372,8 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region,
if (!info) if (!info)
return -ENOMEM; return -ENOMEM;
info->overlay = nd->overlay;
/* Read FPGA region properties from the overlay */ /* Read FPGA region properties from the overlay */
if (of_property_read_bool(nd->overlay, "partial-fpga-config")) if (of_property_read_bool(nd->overlay, "partial-fpga-config"))
info->flags |= FPGA_MGR_PARTIAL_RECONFIG; info->flags |= FPGA_MGR_PARTIAL_RECONFIG;
...@@ -421,7 +422,8 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region, ...@@ -421,7 +422,8 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region,
} }
region->info = info; region->info = info;
ret = fpga_region_program_fpga(region, nd->overlay);
ret = fpga_region_program_fpga(region);
if (ret) { if (ret) {
fpga_image_info_free(info); fpga_image_info_free(info);
region->info = NULL; region->info = NULL;
......
...@@ -89,6 +89,7 @@ enum fpga_mgr_states { ...@@ -89,6 +89,7 @@ enum fpga_mgr_states {
* @buf: contiguous buffer containing FPGA image * @buf: contiguous buffer containing FPGA image
* @count: size of buf * @count: size of buf
* @dev: device that owns this * @dev: device that owns this
* @overlay: Device Tree overlay
*/ */
struct fpga_image_info { struct fpga_image_info {
u32 flags; u32 flags;
...@@ -100,6 +101,9 @@ struct fpga_image_info { ...@@ -100,6 +101,9 @@ struct fpga_image_info {
const char *buf; const char *buf;
size_t count; size_t count;
struct device *dev; struct device *dev;
#ifdef CONFIG_OF
struct device_node *overlay;
#endif
}; };
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment