Commit 643ef23b authored by Tony Nguyen's avatar Tony Nguyen

ice: Introduce local var for readability

Based on previous feedback[1], introduce a local var to make things more
readable.

[1] https://lore.kernel.org/netdev/20220315203218.607f612b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
parent 388740b3
...@@ -5046,8 +5046,11 @@ static void ice_setup_mc_magic_wake(struct ice_pf *pf) ...@@ -5046,8 +5046,11 @@ static void ice_setup_mc_magic_wake(struct ice_pf *pf)
static void ice_remove(struct pci_dev *pdev) static void ice_remove(struct pci_dev *pdev)
{ {
struct ice_pf *pf = pci_get_drvdata(pdev); struct ice_pf *pf = pci_get_drvdata(pdev);
struct ice_hw *hw;
int i; int i;
hw = &pf->hw;
ice_devlink_unregister(pf); ice_devlink_unregister(pf);
for (i = 0; i < ICE_MAX_RESET_WAIT; i++) { for (i = 0; i < ICE_MAX_RESET_WAIT; i++) {
if (!ice_is_reset_in_progress(pf->state)) if (!ice_is_reset_in_progress(pf->state))
...@@ -5080,7 +5083,7 @@ static void ice_remove(struct pci_dev *pdev) ...@@ -5080,7 +5083,7 @@ static void ice_remove(struct pci_dev *pdev)
ice_remove_arfs(pf); ice_remove_arfs(pf);
ice_setup_mc_magic_wake(pf); ice_setup_mc_magic_wake(pf);
ice_vsi_release_all(pf); ice_vsi_release_all(pf);
mutex_destroy(&(&pf->hw)->fdir_fltr_lock); mutex_destroy(&hw->fdir_fltr_lock);
ice_set_wake(pf); ice_set_wake(pf);
ice_free_irq_msix_misc(pf); ice_free_irq_msix_misc(pf);
ice_for_each_vsi(pf, i) { ice_for_each_vsi(pf, i) {
...@@ -5092,13 +5095,13 @@ static void ice_remove(struct pci_dev *pdev) ...@@ -5092,13 +5095,13 @@ static void ice_remove(struct pci_dev *pdev)
pf->vsi_stats = NULL; pf->vsi_stats = NULL;
ice_deinit_pf(pf); ice_deinit_pf(pf);
ice_devlink_destroy_regions(pf); ice_devlink_destroy_regions(pf);
ice_deinit_hw(&pf->hw); ice_deinit_hw(hw);
/* Issue a PFR as part of the prescribed driver unload flow. Do not /* Issue a PFR as part of the prescribed driver unload flow. Do not
* do it via ice_schedule_reset() since there is no need to rebuild * do it via ice_schedule_reset() since there is no need to rebuild
* and the service task is already stopped. * and the service task is already stopped.
*/ */
ice_reset(&pf->hw, ICE_RESET_PFR); ice_reset(hw, ICE_RESET_PFR);
pci_wait_for_pending_transaction(pdev); pci_wait_for_pending_transaction(pdev);
ice_clear_interrupt_scheme(pf); ice_clear_interrupt_scheme(pf);
pci_disable_pcie_error_reporting(pdev); pci_disable_pcie_error_reporting(pdev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment