Commit 646188c9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski

net: dsa: Fix off by one in dsa_loop_port_vlan_add()

The > comparison is intended to be >= to prevent reading beyond the
end of the ps->vlans[] array.  It doesn't affect run time though because
the ps->vlans[] array has VLAN_N_VID (4096) elements and the vlan->vid
cannot be > 4094 because it is checked earlier.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/YAbyb5kBJQlpYCs2@mwandaSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0fe2f273
...@@ -207,7 +207,7 @@ static int dsa_loop_port_vlan_add(struct dsa_switch *ds, int port, ...@@ -207,7 +207,7 @@ static int dsa_loop_port_vlan_add(struct dsa_switch *ds, int port,
struct mii_bus *bus = ps->bus; struct mii_bus *bus = ps->bus;
struct dsa_loop_vlan *vl; struct dsa_loop_vlan *vl;
if (vlan->vid > ARRAY_SIZE(ps->vlans)) if (vlan->vid >= ARRAY_SIZE(ps->vlans))
return -ERANGE; return -ERANGE;
/* Just do a sleeping operation to make lockdep checks effective */ /* Just do a sleeping operation to make lockdep checks effective */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment