Commit 65c6ee90 authored by Dan Carpenter's avatar Dan Carpenter Committed by Johannes Berg

wifi: iwlwifi: uninitialized variable in iwl_acpi_get_ppag_table()

This is an error path and Smatch complains that "tbl_rev" is uninitialized
on this path.  All the other functions follow this same patter where they
set the error code and goto out_free so that's probably what was intended
here as well.

Fixes: e8e10a37 ("iwlwifi: acpi: move ppag code from mvm to fw/acpi")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://msgid.link/09900c01-6540-4a32-9451-563da0029cb6@moroto.mountainSigned-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent c6ebb5b6
...@@ -1116,6 +1116,9 @@ int iwl_acpi_get_ppag_table(struct iwl_fw_runtime *fwrt) ...@@ -1116,6 +1116,9 @@ int iwl_acpi_get_ppag_table(struct iwl_fw_runtime *fwrt)
goto read_table; goto read_table;
} }
ret = PTR_ERR(wifi_pkg);
goto out_free;
read_table: read_table:
fwrt->ppag_ver = tbl_rev; fwrt->ppag_ver = tbl_rev;
flags = &wifi_pkg->package.elements[1]; flags = &wifi_pkg->package.elements[1];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment