Commit 662c653b authored by Liu Bo's avatar Liu Bo Committed by David Sterba

Btrfs: grab write lock directly if write_lock_level is the max level

Typically, when acquiring root node's lock, btrfs tries its best to get
read lock and trade for write lock if @write_lock_level implies to do so.

In case of (cow && (p->keep_locks || p->lowest_level)), write_lock_level
is set to BTRFS_MAX_LEVEL, which means we need to acquire root node's
write lock directly.

In this particular case, the dance of acquiring read lock and then trading
for write lock can be saved.
Signed-off-by: default avatarLiu Bo <bo.liu@linux.alibaba.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 1fc28d8e
...@@ -2632,19 +2632,24 @@ static struct extent_buffer *btrfs_search_slot_get_root(struct btrfs_root *root, ...@@ -2632,19 +2632,24 @@ static struct extent_buffer *btrfs_search_slot_get_root(struct btrfs_root *root,
} }
/* /*
* We don't know the level of the root node until we actually have it * If the level is set to maximum, we can skip trying to get the read
* read locked * lock.
*/
if (write_lock_level < BTRFS_MAX_LEVEL) {
/*
* We don't know the level of the root node until we actually
* have it read locked
*/ */
b = btrfs_read_lock_root_node(root); b = btrfs_read_lock_root_node(root);
level = btrfs_header_level(b); level = btrfs_header_level(b);
if (level > write_lock_level) if (level > write_lock_level)
goto out; goto out;
/* /* Whoops, must trade for write lock */
* whoops, must trade for write lock
*/
btrfs_tree_read_unlock(b); btrfs_tree_read_unlock(b);
free_extent_buffer(b); free_extent_buffer(b);
}
b = btrfs_lock_root_node(root); b = btrfs_lock_root_node(root);
root_lock = BTRFS_WRITE_LOCK; root_lock = BTRFS_WRITE_LOCK;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment