Commit 6636fa3c authored by Monam Agarwal's avatar Monam Agarwal Committed by Greg Kroah-Hartman

Staging: rts5139: Fix incorrect type in assignment in rts51x_fop.c

This patch fixes following sparse warning in rts51x_fop.c
Warning: incorrect type in assignment
Signed-off-by: default avatarMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent abe5d64d
...@@ -93,7 +93,7 @@ static int rts51x_sd_direct_cmnd(struct rts51x_chip *chip, ...@@ -93,7 +93,7 @@ static int rts51x_sd_direct_cmnd(struct rts51x_chip *chip,
} }
retval = retval =
copy_to_user((void *)cmnd->buf, (void *)buf, cmnd->buf_len); copy_to_user(cmnd->buf, (void *)buf, cmnd->buf_len);
if (retval) { if (retval) {
kfree(buf); kfree(buf);
TRACE_RET(chip, STATUS_NOMEM); TRACE_RET(chip, STATUS_NOMEM);
...@@ -109,7 +109,7 @@ static int rts51x_sd_direct_cmnd(struct rts51x_chip *chip, ...@@ -109,7 +109,7 @@ static int rts51x_sd_direct_cmnd(struct rts51x_chip *chip,
TRACE_RET(chip, STATUS_NOMEM); TRACE_RET(chip, STATUS_NOMEM);
retval = retval =
copy_from_user((void *)buf, (void *)cmnd->buf, copy_from_user((void *)buf, cmnd->buf,
cmnd->buf_len); cmnd->buf_len);
if (retval) { if (retval) {
kfree(buf); kfree(buf);
...@@ -154,7 +154,7 @@ static int rts51x_sd_get_rsp(struct rts51x_chip *chip, struct sd_rsp *rsp) ...@@ -154,7 +154,7 @@ static int rts51x_sd_get_rsp(struct rts51x_chip *chip, struct sd_rsp *rsp)
else else
count = (rsp->rsp_len < 6) ? rsp->rsp_len : 6; count = (rsp->rsp_len < 6) ? rsp->rsp_len : 6;
retval = copy_to_user((void *)rsp->rsp, (void *)sd_card->rsp, count); retval = copy_to_user(rsp->rsp, (void *)sd_card->rsp, count);
if (retval) if (retval)
TRACE_RET(chip, STATUS_NOMEM); TRACE_RET(chip, STATUS_NOMEM);
...@@ -250,7 +250,7 @@ long rts51x_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) ...@@ -250,7 +250,7 @@ long rts51x_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
switch (cmd) { switch (cmd) {
case RTS5139_IOC_SD_DIRECT: case RTS5139_IOC_SD_DIRECT:
retval = retval =
copy_from_user((void *)&cmnd, (void *)arg, copy_from_user((void *)&cmnd, (void __user *)arg,
sizeof(struct sd_direct_cmnd)); sizeof(struct sd_direct_cmnd));
if (retval) { if (retval) {
retval = -ENOMEM; retval = -ENOMEM;
...@@ -265,7 +265,7 @@ long rts51x_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) ...@@ -265,7 +265,7 @@ long rts51x_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
case RTS5139_IOC_SD_GET_RSP: case RTS5139_IOC_SD_GET_RSP:
retval = retval =
copy_from_user((void *)&rsp, (void *)arg, copy_from_user(&rsp, (void __user *)arg,
sizeof(struct sd_rsp)); sizeof(struct sd_rsp));
if (retval) { if (retval) {
retval = -ENOMEM; retval = -ENOMEM;
......
...@@ -35,12 +35,12 @@ ...@@ -35,12 +35,12 @@
struct sd_direct_cmnd { struct sd_direct_cmnd {
u8 cmnd[12]; u8 cmnd[12];
void *buf; void __user *buf;
int buf_len; int buf_len;
}; };
struct sd_rsp { struct sd_rsp {
void *rsp; void __user *rsp;
int rsp_len; int rsp_len;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment