Commit 66dcfea7 authored by Dave Jones's avatar Dave Jones

[CPUFREQ] speedstep-centrino: quieten driver (Venkatesh Pallipadi)

Patch to remove speedstep-centrino error messages getting printed by default.
Print them only when debug flags are enabled.

The reason for this patch is -
With the multiple drivers model that we have now, any installation will try
different drivers one after the other, until one of them succeeds. So,
failure to add speedstep-centrino alone doesn't mean error, as some other
driver (say acpi.ko) can succeed later and system will still be able to use
speedstep. Printing the error whenever speedstep-centrino fails can confuse
the enduser.
Signed-off-by: default avatarVenkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: default avatarDominik Brodowski <linux@brodo.de>
Signed-off-by: default avatarDave Jones <davej@redhat.com>
parent d47c0fce
...@@ -241,7 +241,7 @@ static int centrino_cpu_init_table(struct cpufreq_policy *policy) ...@@ -241,7 +241,7 @@ static int centrino_cpu_init_table(struct cpufreq_policy *policy)
if (model->cpu_id == NULL) { if (model->cpu_id == NULL) {
/* No match at all */ /* No match at all */
printk(KERN_INFO PFX "no support for CPU model \"%s\": " dprintk(KERN_INFO PFX "no support for CPU model \"%s\": "
"send /proc/cpuinfo to " MAINTAINER "\n", "send /proc/cpuinfo to " MAINTAINER "\n",
cpu->x86_model_id); cpu->x86_model_id);
return -ENOENT; return -ENOENT;
...@@ -249,10 +249,10 @@ static int centrino_cpu_init_table(struct cpufreq_policy *policy) ...@@ -249,10 +249,10 @@ static int centrino_cpu_init_table(struct cpufreq_policy *policy)
if (model->op_points == NULL) { if (model->op_points == NULL) {
/* Matched a non-match */ /* Matched a non-match */
printk(KERN_INFO PFX "no table support for CPU model \"%s\": \n", dprintk(KERN_INFO PFX "no table support for CPU model \"%s\": \n",
cpu->x86_model_id); cpu->x86_model_id);
#ifdef CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI #ifdef CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI
printk(KERN_INFO PFX "try compiling with CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI enabled\n"); dprintk(KERN_INFO PFX "try compiling with CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI enabled\n");
#endif #endif
return -ENOENT; return -ENOENT;
} }
...@@ -384,7 +384,7 @@ static int centrino_cpu_init_acpi(struct cpufreq_policy *policy) ...@@ -384,7 +384,7 @@ static int centrino_cpu_init_acpi(struct cpufreq_policy *policy)
/* register with ACPI core */ /* register with ACPI core */
if (acpi_processor_register_performance(&p, cpu)) { if (acpi_processor_register_performance(&p, cpu)) {
printk(KERN_INFO PFX "obtaining ACPI data failed\n"); dprintk(KERN_INFO PFX "obtaining ACPI data failed\n");
return -EIO; return -EIO;
} }
...@@ -482,7 +482,7 @@ static int centrino_cpu_init_acpi(struct cpufreq_policy *policy) ...@@ -482,7 +482,7 @@ static int centrino_cpu_init_acpi(struct cpufreq_policy *policy)
kfree(centrino_model[cpu]); kfree(centrino_model[cpu]);
err_unreg: err_unreg:
acpi_processor_unregister_performance(&p, cpu); acpi_processor_unregister_performance(&p, cpu);
printk(KERN_INFO PFX "invalid ACPI data\n"); dprintk(KERN_INFO PFX "invalid ACPI data\n");
return (result); return (result);
} }
#else #else
...@@ -513,7 +513,7 @@ static int centrino_cpu_init(struct cpufreq_policy *policy) ...@@ -513,7 +513,7 @@ static int centrino_cpu_init(struct cpufreq_policy *policy)
return -ENODEV; return -ENODEV;
if (!centrino_cpu[policy->cpu]) { if (!centrino_cpu[policy->cpu]) {
printk(KERN_INFO PFX "found unsupported CPU with " dprintk(KERN_INFO PFX "found unsupported CPU with "
"Enhanced SpeedStep: send /proc/cpuinfo to " "Enhanced SpeedStep: send /proc/cpuinfo to "
MAINTAINER "\n"); MAINTAINER "\n");
return -ENODEV; return -ENODEV;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment