Commit 68199bd1 authored by Tony Cheng's avatar Tony Cheng Committed by Alex Deucher

drm/amd/display: Move address tracking out of HUBP

[Why]
We sometime require remapping of FB address space to UMA

[How]
Move address tracking up a layer before we apply address translation
Signed-off-by: default avatarTony Cheng <tony.cheng@amd.com>
Reviewed-by: default avatarCharlene Liu <Charlene.Liu@amd.com>
Acked-by: default avatarLeo Li <sunpeng.li@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2068afe6
...@@ -457,9 +457,6 @@ bool hubp1_program_surface_flip_and_addr( ...@@ -457,9 +457,6 @@ bool hubp1_program_surface_flip_and_addr(
hubp->request_address = *address; hubp->request_address = *address;
if (flip_immediate)
hubp->current_address = *address;
return true; return true;
} }
...@@ -695,7 +692,6 @@ bool hubp1_is_flip_pending(struct hubp *hubp) ...@@ -695,7 +692,6 @@ bool hubp1_is_flip_pending(struct hubp *hubp)
if (earliest_inuse_address.grph.addr.quad_part != hubp->request_address.grph.addr.quad_part) if (earliest_inuse_address.grph.addr.quad_part != hubp->request_address.grph.addr.quad_part)
return true; return true;
hubp->current_address = hubp->request_address;
return false; return false;
} }
......
...@@ -1157,12 +1157,19 @@ static void dcn10_update_plane_addr(const struct dc *dc, struct pipe_ctx *pipe_c ...@@ -1157,12 +1157,19 @@ static void dcn10_update_plane_addr(const struct dc *dc, struct pipe_ctx *pipe_c
if (plane_state == NULL) if (plane_state == NULL)
return; return;
addr_patched = patch_address_for_sbs_tb_stereo(pipe_ctx, &addr); addr_patched = patch_address_for_sbs_tb_stereo(pipe_ctx, &addr);
pipe_ctx->plane_res.hubp->funcs->hubp_program_surface_flip_and_addr( pipe_ctx->plane_res.hubp->funcs->hubp_program_surface_flip_and_addr(
pipe_ctx->plane_res.hubp, pipe_ctx->plane_res.hubp,
&plane_state->address, &plane_state->address,
plane_state->flip_immediate); plane_state->flip_immediate);
plane_state->status.requested_address = plane_state->address; plane_state->status.requested_address = plane_state->address;
if (plane_state->flip_immediate)
plane_state->status.current_address = plane_state->address;
if (addr_patched) if (addr_patched)
pipe_ctx->plane_state->address.grph_stereo.left_addr = addr; pipe_ctx->plane_state->address.grph_stereo.left_addr = addr;
} }
...@@ -2533,16 +2540,20 @@ static void dcn10_update_pending_status(struct pipe_ctx *pipe_ctx) ...@@ -2533,16 +2540,20 @@ static void dcn10_update_pending_status(struct pipe_ctx *pipe_ctx)
{ {
struct dc_plane_state *plane_state = pipe_ctx->plane_state; struct dc_plane_state *plane_state = pipe_ctx->plane_state;
struct timing_generator *tg = pipe_ctx->stream_res.tg; struct timing_generator *tg = pipe_ctx->stream_res.tg;
bool flip_pending;
if (plane_state == NULL) if (plane_state == NULL)
return; return;
plane_state->status.is_flip_pending = flip_pending = pipe_ctx->plane_res.hubp->funcs->hubp_is_flip_pending(
pipe_ctx->plane_res.hubp->funcs->hubp_is_flip_pending(
pipe_ctx->plane_res.hubp); pipe_ctx->plane_res.hubp);
plane_state->status.current_address = pipe_ctx->plane_res.hubp->current_address; plane_state->status.is_flip_pending = flip_pending;
if (pipe_ctx->plane_res.hubp->current_address.type == PLN_ADDR_TYPE_GRPH_STEREO &&
if (!flip_pending)
plane_state->status.current_address = plane_state->status.requested_address;
if (plane_state->status.current_address.type == PLN_ADDR_TYPE_GRPH_STEREO &&
tg->funcs->is_stereo_left_eye) { tg->funcs->is_stereo_left_eye) {
plane_state->status.is_right_eye = plane_state->status.is_right_eye =
!tg->funcs->is_stereo_left_eye(pipe_ctx->stream_res.tg); !tg->funcs->is_stereo_left_eye(pipe_ctx->stream_res.tg);
......
...@@ -46,7 +46,6 @@ struct hubp { ...@@ -46,7 +46,6 @@ struct hubp {
const struct hubp_funcs *funcs; const struct hubp_funcs *funcs;
struct dc_context *ctx; struct dc_context *ctx;
struct dc_plane_address request_address; struct dc_plane_address request_address;
struct dc_plane_address current_address;
int inst; int inst;
/* run time states */ /* run time states */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment