Commit 68c6beb3 authored by Hannes Frederic Sowa's avatar Hannes Frederic Sowa Committed by David S. Miller

net: add BUG_ON if kernel advertises msg_namelen > sizeof(struct sockaddr_storage)

In that case it is probable that kernel code overwrote part of the
stack. So we should bail out loudly here.

The BUG_ON may be removed in future if we are sure all protocols are
conformant.
Suggested-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f3d33426
...@@ -221,12 +221,13 @@ static int move_addr_to_user(struct sockaddr_storage *kaddr, int klen, ...@@ -221,12 +221,13 @@ static int move_addr_to_user(struct sockaddr_storage *kaddr, int klen,
int err; int err;
int len; int len;
BUG_ON(klen > sizeof(struct sockaddr_storage));
err = get_user(len, ulen); err = get_user(len, ulen);
if (err) if (err)
return err; return err;
if (len > klen) if (len > klen)
len = klen; len = klen;
if (len < 0 || len > sizeof(struct sockaddr_storage)) if (len < 0)
return -EINVAL; return -EINVAL;
if (len) { if (len) {
if (audit_sockaddr(klen, kaddr)) if (audit_sockaddr(klen, kaddr))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment