Commit 68e83498 authored by Nicolas Saenz Julienne's avatar Nicolas Saenz Julienne Committed by Steven Rostedt (VMware)

ftrace: Avoid synchronize_rcu_tasks_rude() call when not necessary

synchronize_rcu_tasks_rude() triggers IPIs and forces rescheduling on
all CPUs. It is a costly operation and, when targeting nohz_full CPUs,
very disrupting (hence the name). So avoid calling it when 'old_hash'
doesn't need to be freed.

Link: https://lkml.kernel.org/r/20210721114726.1545103-1-nsaenzju@redhat.comSigned-off-by: default avatarNicolas Saenz Julienne <nsaenzju@redhat.com>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent 9528c195
...@@ -5985,6 +5985,7 @@ ftrace_graph_release(struct inode *inode, struct file *file) ...@@ -5985,6 +5985,7 @@ ftrace_graph_release(struct inode *inode, struct file *file)
* infrastructure to do the synchronization, thus we must do it * infrastructure to do the synchronization, thus we must do it
* ourselves. * ourselves.
*/ */
if (old_hash != EMPTY_HASH)
synchronize_rcu_tasks_rude(); synchronize_rcu_tasks_rude();
free_ftrace_hash(old_hash); free_ftrace_hash(old_hash);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment