Commit 6eea63c7 authored by Erico Nunes's avatar Erico Nunes Committed by Qiang Yu

drm/lima: fix sched context destroy

The drm sched entity must be flushed before finishing, to account for
jobs potentially still in flight at that time.
Lima did not do this flush until now, so switch the destroy call to the
drm_sched_entity_destroy() wrapper which will take care of that.

This fixes a regression on lima which started since the rework in
commit 2fdb8a8f ("drm/scheduler: rework entity flush, kill and fini")
where some specific types of applications may hang indefinitely.

Fixes: 2fdb8a8f ("drm/scheduler: rework entity flush, kill and fini")
Reviewed-by: default avatarVasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: default avatarErico Nunes <nunes.erico@gmail.com>
Signed-off-by: default avatarQiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230606143247.433018-1-nunes.erico@gmail.com
parent 41136025
...@@ -165,7 +165,7 @@ int lima_sched_context_init(struct lima_sched_pipe *pipe, ...@@ -165,7 +165,7 @@ int lima_sched_context_init(struct lima_sched_pipe *pipe,
void lima_sched_context_fini(struct lima_sched_pipe *pipe, void lima_sched_context_fini(struct lima_sched_pipe *pipe,
struct lima_sched_context *context) struct lima_sched_context *context)
{ {
drm_sched_entity_fini(&context->base); drm_sched_entity_destroy(&context->base);
} }
struct dma_fence *lima_sched_context_queue_task(struct lima_sched_task *task) struct dma_fence *lima_sched_context_queue_task(struct lima_sched_task *task)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment