Commit 6f2af72a authored by Dan Carpenter's avatar Dan Carpenter Committed by Samuel Ortiz

mfd: WM8350 off by one bug

If irq == WM8350_NUM_IRQ that would put us past the end of the array.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 9dffe2a3
...@@ -434,7 +434,7 @@ int wm8350_register_irq(struct wm8350 *wm8350, int irq, ...@@ -434,7 +434,7 @@ int wm8350_register_irq(struct wm8350 *wm8350, int irq,
irq_handler_t handler, unsigned long flags, irq_handler_t handler, unsigned long flags,
const char *name, void *data) const char *name, void *data)
{ {
if (irq < 0 || irq > WM8350_NUM_IRQ || !handler) if (irq < 0 || irq >= WM8350_NUM_IRQ || !handler)
return -EINVAL; return -EINVAL;
if (wm8350->irq[irq].handler) if (wm8350->irq[irq].handler)
...@@ -453,7 +453,7 @@ EXPORT_SYMBOL_GPL(wm8350_register_irq); ...@@ -453,7 +453,7 @@ EXPORT_SYMBOL_GPL(wm8350_register_irq);
int wm8350_free_irq(struct wm8350 *wm8350, int irq) int wm8350_free_irq(struct wm8350 *wm8350, int irq)
{ {
if (irq < 0 || irq > WM8350_NUM_IRQ) if (irq < 0 || irq >= WM8350_NUM_IRQ)
return -EINVAL; return -EINVAL;
wm8350_mask_irq(wm8350, irq); wm8350_mask_irq(wm8350, irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment