Commit 6f3ef5c2 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by David S. Miller

wimax: i2400: Fix memory leak in i2400m_op_rfkill_sw_toggle

In the implementation of i2400m_op_rfkill_sw_toggle() the allocated
buffer for cmd should be released before returning. The
documentation for i2400m_msg_to_dev() says when it returns the buffer
can be reused. Meaning cmd should be released in either case. Move
kfree(cmd) before return to be reached by all execution paths.

Fixes: 2507e6ab ("wimax: i2400: fix memory leak")
Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 63a41746
...@@ -127,12 +127,12 @@ int i2400m_op_rfkill_sw_toggle(struct wimax_dev *wimax_dev, ...@@ -127,12 +127,12 @@ int i2400m_op_rfkill_sw_toggle(struct wimax_dev *wimax_dev,
"%d\n", result); "%d\n", result);
result = 0; result = 0;
error_cmd: error_cmd:
kfree(cmd);
kfree_skb(ack_skb); kfree_skb(ack_skb);
error_msg_to_dev: error_msg_to_dev:
error_alloc: error_alloc:
d_fnend(4, dev, "(wimax_dev %p state %d) = %d\n", d_fnend(4, dev, "(wimax_dev %p state %d) = %d\n",
wimax_dev, state, result); wimax_dev, state, result);
kfree(cmd);
return result; return result;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment