Commit 6f9ec442 authored by Fabio Estevam's avatar Fabio Estevam Committed by Sascha Hauer

ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset

Current code inside babbage_usbhub_reset uses gpio_direction_output with initial value of the GPIO and also sets
the GPIO value via gpio_set_value to the same level right after. This is not needed.

By using gpio_request_one it is possible to set the direction and initial value in one shot.
Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
LAKML-Reference: 1300377359-23212-2-git-send-email-fabio.estevam@freescale.com
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
parent 2d95378b
...@@ -208,18 +208,16 @@ static inline void babbage_usbhub_reset(void) ...@@ -208,18 +208,16 @@ static inline void babbage_usbhub_reset(void)
{ {
int ret; int ret;
/* Bring USB hub out of reset */ /* Reset USB hub */
ret = gpio_request(BABBAGE_USB_HUB_RESET, "GPIO1_7"); ret = gpio_request_one(BABBAGE_USB_HUB_RESET,
GPIOF_OUT_INIT_LOW, "GPIO1_7");
if (ret) { if (ret) {
printk(KERN_ERR"failed to get GPIO_USB_HUB_RESET: %d\n", ret); printk(KERN_ERR"failed to get GPIO_USB_HUB_RESET: %d\n", ret);
return; return;
} }
gpio_direction_output(BABBAGE_USB_HUB_RESET, 0);
/* USB HUB RESET - De-assert USB HUB RESET_N */ msleep(2);
msleep(1); /* Deassert reset */
gpio_set_value(BABBAGE_USB_HUB_RESET, 0);
msleep(1);
gpio_set_value(BABBAGE_USB_HUB_RESET, 1); gpio_set_value(BABBAGE_USB_HUB_RESET, 1);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment