Commit 6fa2cffe authored by Alexander Aring's avatar Alexander Aring Committed by Marcel Holtmann

fakelb: move lock out of iteration

The list need to be protected while iteration which is need when other
list iterates at the same time over this list.
Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent b82b99f1
...@@ -193,9 +193,7 @@ static int fakelb_add_one(struct device *dev) ...@@ -193,9 +193,7 @@ static int fakelb_add_one(struct device *dev)
static void fakelb_del(struct fakelb_phy *phy) static void fakelb_del(struct fakelb_phy *phy)
{ {
write_lock_bh(&fakelb_lock);
list_del(&phy->list); list_del(&phy->list);
write_unlock_bh(&fakelb_lock);
ieee802154_unregister_hw(phy->hw); ieee802154_unregister_hw(phy->hw);
ieee802154_free_hw(phy->hw); ieee802154_free_hw(phy->hw);
...@@ -217,8 +215,10 @@ static int fakelb_probe(struct platform_device *pdev) ...@@ -217,8 +215,10 @@ static int fakelb_probe(struct platform_device *pdev)
return 0; return 0;
err_slave: err_slave:
write_lock_bh(&fakelb_lock);
list_for_each_entry_safe(phy, tmp, &fakelb_phys, list) list_for_each_entry_safe(phy, tmp, &fakelb_phys, list)
fakelb_del(phy); fakelb_del(phy);
write_unlock_bh(&fakelb_lock);
return err; return err;
} }
...@@ -226,9 +226,10 @@ static int fakelb_remove(struct platform_device *pdev) ...@@ -226,9 +226,10 @@ static int fakelb_remove(struct platform_device *pdev)
{ {
struct fakelb_phy *phy, *temp; struct fakelb_phy *phy, *temp;
write_lock_bh(&fakelb_lock);
list_for_each_entry_safe(phy, temp, &fakelb_phys, list) list_for_each_entry_safe(phy, temp, &fakelb_phys, list)
fakelb_del(phy); fakelb_del(phy);
write_unlock_bh(&fakelb_lock);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment