Commit 6fb400d3 authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux

Pull s390 fixes from Martin Schwidefsky:
 "Two small performance tweaks, the plumbing for the execveat system
  call and a couple of bug fixes"

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux:
  s390/uprobes: fix user space PER events
  s390/bpf: Fix JMP_JGE_X (A > X) and JMP_JGT_X (A >= X)
  s390/bpf: Fix ALU_NEG (A = -A)
  s390/mm: avoid using pmd_to_page for !USE_SPLIT_PMD_PTLOCKS
  s390/timex: fix get_tod_clock_ext() inline assembly
  s390: wire up execveat syscall
  s390/kernel: use stnsm 255 instead of stosm 0
  s390/vtime: Get rid of redundant WARN_ON
  s390/zcrypt: kernel oops at insmod of the z90crypt device driver
parents fb005c47 8d1a2427
...@@ -231,7 +231,7 @@ int hypfs_vm_create_files(struct dentry *root) ...@@ -231,7 +231,7 @@ int hypfs_vm_create_files(struct dentry *root)
struct dbfs_d2fc_hdr { struct dbfs_d2fc_hdr {
u64 len; /* Length of d2fc buffer without header */ u64 len; /* Length of d2fc buffer without header */
u16 version; /* Version of header */ u16 version; /* Version of header */
char tod_ext[16]; /* TOD clock for d2fc */ char tod_ext[STORE_CLOCK_EXT_SIZE]; /* TOD clock for d2fc */
u64 count; /* Number of VM guests in d2fc buffer */ u64 count; /* Number of VM guests in d2fc buffer */
char reserved[30]; char reserved[30];
} __attribute__ ((packed)); } __attribute__ ((packed));
......
...@@ -36,7 +36,7 @@ static inline notrace void __arch_local_irq_ssm(unsigned long flags) ...@@ -36,7 +36,7 @@ static inline notrace void __arch_local_irq_ssm(unsigned long flags)
static inline notrace unsigned long arch_local_save_flags(void) static inline notrace unsigned long arch_local_save_flags(void)
{ {
return __arch_local_irq_stosm(0x00); return __arch_local_irq_stnsm(0xff);
} }
static inline notrace unsigned long arch_local_irq_save(void) static inline notrace unsigned long arch_local_irq_save(void)
......
...@@ -68,19 +68,21 @@ static inline void local_tick_enable(unsigned long long comp) ...@@ -68,19 +68,21 @@ static inline void local_tick_enable(unsigned long long comp)
} }
#define CLOCK_TICK_RATE 1193180 /* Underlying HZ */ #define CLOCK_TICK_RATE 1193180 /* Underlying HZ */
#define STORE_CLOCK_EXT_SIZE 16 /* stcke writes 16 bytes */
typedef unsigned long long cycles_t; typedef unsigned long long cycles_t;
static inline void get_tod_clock_ext(char clk[16]) static inline void get_tod_clock_ext(char *clk)
{ {
typedef struct { char _[sizeof(clk)]; } addrtype; typedef struct { char _[STORE_CLOCK_EXT_SIZE]; } addrtype;
asm volatile("stcke %0" : "=Q" (*(addrtype *) clk) : : "cc"); asm volatile("stcke %0" : "=Q" (*(addrtype *) clk) : : "cc");
} }
static inline unsigned long long get_tod_clock(void) static inline unsigned long long get_tod_clock(void)
{ {
unsigned char clk[16]; unsigned char clk[STORE_CLOCK_EXT_SIZE];
get_tod_clock_ext(clk); get_tod_clock_ext(clk);
return *((unsigned long long *)&clk[1]); return *((unsigned long long *)&clk[1]);
} }
......
...@@ -289,7 +289,8 @@ ...@@ -289,7 +289,8 @@
#define __NR_bpf 351 #define __NR_bpf 351
#define __NR_s390_pci_mmio_write 352 #define __NR_s390_pci_mmio_write 352
#define __NR_s390_pci_mmio_read 353 #define __NR_s390_pci_mmio_read 353
#define NR_syscalls 354 #define __NR_execveat 354
#define NR_syscalls 355
/* /*
* There are some system calls that are not present on 64 bit, some * There are some system calls that are not present on 64 bit, some
......
...@@ -362,3 +362,4 @@ SYSCALL(sys_memfd_create,sys_memfd_create,compat_sys_memfd_create) /* 350 */ ...@@ -362,3 +362,4 @@ SYSCALL(sys_memfd_create,sys_memfd_create,compat_sys_memfd_create) /* 350 */
SYSCALL(sys_bpf,sys_bpf,compat_sys_bpf) SYSCALL(sys_bpf,sys_bpf,compat_sys_bpf)
SYSCALL(sys_ni_syscall,sys_s390_pci_mmio_write,compat_sys_s390_pci_mmio_write) SYSCALL(sys_ni_syscall,sys_s390_pci_mmio_write,compat_sys_s390_pci_mmio_write)
SYSCALL(sys_ni_syscall,sys_s390_pci_mmio_read,compat_sys_s390_pci_mmio_read) SYSCALL(sys_ni_syscall,sys_s390_pci_mmio_read,compat_sys_s390_pci_mmio_read)
SYSCALL(sys_execveat,sys_execveat,compat_sys_execveat)
...@@ -48,6 +48,30 @@ bool arch_uprobe_xol_was_trapped(struct task_struct *tsk) ...@@ -48,6 +48,30 @@ bool arch_uprobe_xol_was_trapped(struct task_struct *tsk)
return false; return false;
} }
static int check_per_event(unsigned short cause, unsigned long control,
struct pt_regs *regs)
{
if (!(regs->psw.mask & PSW_MASK_PER))
return 0;
/* user space single step */
if (control == 0)
return 1;
/* over indication for storage alteration */
if ((control & 0x20200000) && (cause & 0x2000))
return 1;
if (cause & 0x8000) {
/* all branches */
if ((control & 0x80800000) == 0x80000000)
return 1;
/* branch into selected range */
if (((control & 0x80800000) == 0x80800000) &&
regs->psw.addr >= current->thread.per_user.start &&
regs->psw.addr <= current->thread.per_user.end)
return 1;
}
return 0;
}
int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs) int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
{ {
int fixup = probe_get_fixup_type(auprobe->insn); int fixup = probe_get_fixup_type(auprobe->insn);
...@@ -71,9 +95,13 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs) ...@@ -71,9 +95,13 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
if (regs->psw.addr - utask->xol_vaddr == ilen) if (regs->psw.addr - utask->xol_vaddr == ilen)
regs->psw.addr = utask->vaddr + ilen; regs->psw.addr = utask->vaddr + ilen;
} }
/* If per tracing was active generate trap */ if (check_per_event(current->thread.per_event.cause,
if (regs->psw.mask & PSW_MASK_PER) current->thread.per_user.control, regs)) {
do_per_trap(regs); /* fix per address */
current->thread.per_event.address = utask->vaddr;
/* trigger per event */
set_pt_regs_flag(regs, PIF_PER_TRAP);
}
return 0; return 0;
} }
...@@ -106,6 +134,7 @@ void arch_uprobe_abort_xol(struct arch_uprobe *auprobe, struct pt_regs *regs) ...@@ -106,6 +134,7 @@ void arch_uprobe_abort_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
clear_thread_flag(TIF_UPROBE_SINGLESTEP); clear_thread_flag(TIF_UPROBE_SINGLESTEP);
regs->int_code = auprobe->saved_int_code; regs->int_code = auprobe->saved_int_code;
regs->psw.addr = current->utask->vaddr; regs->psw.addr = current->utask->vaddr;
current->thread.per_event.address = current->utask->vaddr;
} }
unsigned long arch_uretprobe_hijack_return_addr(unsigned long trampoline, unsigned long arch_uretprobe_hijack_return_addr(unsigned long trampoline,
...@@ -146,17 +175,20 @@ static void adjust_psw_addr(psw_t *psw, unsigned long len) ...@@ -146,17 +175,20 @@ static void adjust_psw_addr(psw_t *psw, unsigned long len)
__rc; \ __rc; \
}) })
#define emu_store_ril(ptr, input) \ #define emu_store_ril(regs, ptr, input) \
({ \ ({ \
unsigned int mask = sizeof(*(ptr)) - 1; \ unsigned int mask = sizeof(*(ptr)) - 1; \
__typeof__(ptr) __ptr = (ptr); \
int __rc = 0; \ int __rc = 0; \
\ \
if (!test_facility(34)) \ if (!test_facility(34)) \
__rc = EMU_ILLEGAL_OP; \ __rc = EMU_ILLEGAL_OP; \
else if ((u64 __force)ptr & mask) \ else if ((u64 __force)__ptr & mask) \
__rc = EMU_SPECIFICATION; \ __rc = EMU_SPECIFICATION; \
else if (put_user(*(input), ptr)) \ else if (put_user(*(input), __ptr)) \
__rc = EMU_ADDRESSING; \ __rc = EMU_ADDRESSING; \
if (__rc == 0) \
sim_stor_event(regs, __ptr, mask + 1); \
__rc; \ __rc; \
}) })
...@@ -197,6 +229,25 @@ union split_register { ...@@ -197,6 +229,25 @@ union split_register {
s16 s16[4]; s16 s16[4];
}; };
/*
* If user per registers are setup to trace storage alterations and an
* emulated store took place on a fitting address a user trap is generated.
*/
static void sim_stor_event(struct pt_regs *regs, void *addr, int len)
{
if (!(regs->psw.mask & PSW_MASK_PER))
return;
if (!(current->thread.per_user.control & PER_EVENT_STORE))
return;
if ((void *)current->thread.per_user.start > (addr + len))
return;
if ((void *)current->thread.per_user.end < addr)
return;
current->thread.per_event.address = regs->psw.addr;
current->thread.per_event.cause = PER_EVENT_STORE >> 16;
set_pt_regs_flag(regs, PIF_PER_TRAP);
}
/* /*
* pc relative instructions are emulated, since parameters may not be * pc relative instructions are emulated, since parameters may not be
* accessible from the xol area due to range limitations. * accessible from the xol area due to range limitations.
...@@ -249,13 +300,13 @@ static void handle_insn_ril(struct arch_uprobe *auprobe, struct pt_regs *regs) ...@@ -249,13 +300,13 @@ static void handle_insn_ril(struct arch_uprobe *auprobe, struct pt_regs *regs)
rc = emu_load_ril((u32 __user *)uptr, &rx->u64); rc = emu_load_ril((u32 __user *)uptr, &rx->u64);
break; break;
case 0x07: /* sthrl */ case 0x07: /* sthrl */
rc = emu_store_ril((u16 __user *)uptr, &rx->u16[3]); rc = emu_store_ril(regs, (u16 __user *)uptr, &rx->u16[3]);
break; break;
case 0x0b: /* stgrl */ case 0x0b: /* stgrl */
rc = emu_store_ril((u64 __user *)uptr, &rx->u64); rc = emu_store_ril(regs, (u64 __user *)uptr, &rx->u64);
break; break;
case 0x0f: /* strl */ case 0x0f: /* strl */
rc = emu_store_ril((u32 __user *)uptr, &rx->u32[1]); rc = emu_store_ril(regs, (u32 __user *)uptr, &rx->u32[1]);
break; break;
} }
break; break;
......
...@@ -128,8 +128,6 @@ void vtime_account_irq_enter(struct task_struct *tsk) ...@@ -128,8 +128,6 @@ void vtime_account_irq_enter(struct task_struct *tsk)
struct thread_info *ti = task_thread_info(tsk); struct thread_info *ti = task_thread_info(tsk);
u64 timer, system; u64 timer, system;
WARN_ON_ONCE(!irqs_disabled());
timer = S390_lowcore.last_update_timer; timer = S390_lowcore.last_update_timer;
S390_lowcore.last_update_timer = get_vtimer(); S390_lowcore.last_update_timer = get_vtimer();
S390_lowcore.system_timer += timer - S390_lowcore.last_update_timer; S390_lowcore.system_timer += timer - S390_lowcore.last_update_timer;
......
...@@ -322,11 +322,12 @@ static int gmap_alloc_table(struct gmap *gmap, unsigned long *table, ...@@ -322,11 +322,12 @@ static int gmap_alloc_table(struct gmap *gmap, unsigned long *table,
static unsigned long __gmap_segment_gaddr(unsigned long *entry) static unsigned long __gmap_segment_gaddr(unsigned long *entry)
{ {
struct page *page; struct page *page;
unsigned long offset; unsigned long offset, mask;
offset = (unsigned long) entry / sizeof(unsigned long); offset = (unsigned long) entry / sizeof(unsigned long);
offset = (offset & (PTRS_PER_PMD - 1)) * PMD_SIZE; offset = (offset & (PTRS_PER_PMD - 1)) * PMD_SIZE;
page = pmd_to_page((pmd_t *) entry); mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1);
page = virt_to_page((void *)((unsigned long) entry & mask));
return page->index + offset; return page->index + offset;
} }
......
...@@ -431,8 +431,8 @@ static int bpf_jit_insn(struct bpf_jit *jit, struct sock_filter *filter, ...@@ -431,8 +431,8 @@ static int bpf_jit_insn(struct bpf_jit *jit, struct sock_filter *filter,
EMIT4_DISP(0x88500000, K); EMIT4_DISP(0x88500000, K);
break; break;
case BPF_ALU | BPF_NEG: /* A = -A */ case BPF_ALU | BPF_NEG: /* A = -A */
/* lnr %r5,%r5 */ /* lcr %r5,%r5 */
EMIT2(0x1155); EMIT2(0x1355);
break; break;
case BPF_JMP | BPF_JA: /* ip += K */ case BPF_JMP | BPF_JA: /* ip += K */
offset = addrs[i + K] + jit->start - jit->prg; offset = addrs[i + K] + jit->start - jit->prg;
...@@ -502,8 +502,8 @@ branch: if (filter->jt == filter->jf) { ...@@ -502,8 +502,8 @@ branch: if (filter->jt == filter->jf) {
xbranch: /* Emit compare if the branch targets are different */ xbranch: /* Emit compare if the branch targets are different */
if (filter->jt != filter->jf) { if (filter->jt != filter->jf) {
jit->seen |= SEEN_XREG; jit->seen |= SEEN_XREG;
/* cr %r5,%r12 */ /* clr %r5,%r12 */
EMIT2(0x195c); EMIT2(0x155c);
} }
goto branch; goto branch;
case BPF_JMP | BPF_JSET | BPF_X: /* ip += (A & X) ? jt : jf */ case BPF_JMP | BPF_JSET | BPF_X: /* ip += (A & X) ? jt : jf */
......
...@@ -1163,8 +1163,12 @@ static inline int ap_test_config_card_id(unsigned int id) ...@@ -1163,8 +1163,12 @@ static inline int ap_test_config_card_id(unsigned int id)
*/ */
static inline int ap_test_config_domain(unsigned int domain) static inline int ap_test_config_domain(unsigned int domain)
{ {
if (!ap_configuration) if (!ap_configuration) /* QCI not supported */
return 1; if (domain < 16)
return 1; /* then domains 0...15 are configured */
else
return 0;
else
return ap_test_config(ap_configuration->aqm, domain); return ap_test_config(ap_configuration->aqm, domain);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment