Commit 6fc812b4 authored by Johan Hovold's avatar Johan Hovold Committed by Jiri Slaby

USB: serial: fix infinite wait_until_sent timeout

commit f528bf4f upstream.

Make sure to handle an infinite timeout (0).

Note that wait_until_sent is currently never called with a 0-timeout
argument due to a bug in tty_wait_until_sent.

Fixes: dcf01050 ("USB: serial: add generic wait_until_sent
implementation")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent a1f87712
...@@ -261,6 +261,7 @@ void usb_serial_generic_wait_until_sent(struct tty_struct *tty, long timeout) ...@@ -261,6 +261,7 @@ void usb_serial_generic_wait_until_sent(struct tty_struct *tty, long timeout)
* character or at least one jiffy. * character or at least one jiffy.
*/ */
period = max_t(unsigned long, (10 * HZ / bps), 1); period = max_t(unsigned long, (10 * HZ / bps), 1);
if (timeout)
period = min_t(unsigned long, period, timeout); period = min_t(unsigned long, period, timeout);
dev_dbg(&port->dev, "%s - timeout = %u ms, period = %u ms\n", dev_dbg(&port->dev, "%s - timeout = %u ms, period = %u ms\n",
...@@ -271,7 +272,7 @@ void usb_serial_generic_wait_until_sent(struct tty_struct *tty, long timeout) ...@@ -271,7 +272,7 @@ void usb_serial_generic_wait_until_sent(struct tty_struct *tty, long timeout)
schedule_timeout_interruptible(period); schedule_timeout_interruptible(period);
if (signal_pending(current)) if (signal_pending(current))
break; break;
if (time_after(jiffies, expire)) if (timeout && time_after(jiffies, expire))
break; break;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment