Commit 6fc9a147 authored by Alexandre TORGUE's avatar Alexandre TORGUE Committed by Greg Kroah-Hartman

pinctrl: stm32: Fix bad function call

commit b7c747d4 upstream.

In stm32_pconf_parse_conf function, stm32_pmx_gpio_set_direction is
called with wrong parameter value. Indeed, using NULL value for range
will raise an oops.

Fixes: aceb16dc ("pinctrl: Add STM32 MCUs support")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlexandre TORGUE <alexandre.torgue@st.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 57564497
...@@ -786,7 +786,7 @@ static int stm32_pconf_parse_conf(struct pinctrl_dev *pctldev, ...@@ -786,7 +786,7 @@ static int stm32_pconf_parse_conf(struct pinctrl_dev *pctldev,
break; break;
case PIN_CONFIG_OUTPUT: case PIN_CONFIG_OUTPUT:
__stm32_gpio_set(bank, offset, arg); __stm32_gpio_set(bank, offset, arg);
ret = stm32_pmx_gpio_set_direction(pctldev, NULL, pin, false); ret = stm32_pmx_gpio_set_direction(pctldev, range, pin, false);
break; break;
default: default:
ret = -EINVAL; ret = -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment