Commit 70b416af authored by Rob Herring's avatar Rob Herring

dt-bindings: arm,coresight-cti: Add missing additionalProperties on child nodes

Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.

Adding additionalProperties constraint on 'trig-conns' nodes results in
warnings that 'cpu' and 'arm,cs-dev-assoc' are not allowed. These are
already defined for the parent node, but need to be duplicated for the
child node. Drop the free form description that the properties also apply
to the child nodes.
Acked-by: default avatarConor Dooley <conor.dooley@microchip.com>
Reviewed-by: default avatarMike Leach <mike.leach@linaro.org>
Link: https://lore.kernel.org/r/20230925220511.2026514-2-robh@kernel.orgSigned-off-by: default avatarRob Herring <robh@kernel.org>
parent 5027cf58
...@@ -93,9 +93,7 @@ properties: ...@@ -93,9 +93,7 @@ properties:
cpu: cpu:
description: description:
Handle to cpu this device is associated with. This must appear in the Handle to cpu this CTI is associated with.
base cti node if compatible string arm,coresight-cti-v8-arch is used,
or may appear in a trig-conns child node when appropriate.
power-domains: power-domains:
maxItems: 1 maxItems: 1
...@@ -112,12 +110,12 @@ properties: ...@@ -112,12 +110,12 @@ properties:
description: description:
defines a phandle reference to an associated CoreSight trace device. defines a phandle reference to an associated CoreSight trace device.
When the associated trace device is enabled, then the respective CTI When the associated trace device is enabled, then the respective CTI
will be enabled. Use in a trig-conns node, or in CTI base node when will be enabled. Use in CTI base node when compatible string
compatible string arm,coresight-cti-v8-arch used. If the associated arm,coresight-cti-v8-arch used. If the associated device has not been
device has not been registered then the node name will be stored as registered then the node name will be stored as the connection name for
the connection name for later resolution. If the associated device is later resolution. If the associated device is not a CoreSight device or
not a CoreSight device or not registered then the node name will remain not registered then the node name will remain the connection name and
the connection name and automatic enabling will not occur. automatic enabling will not occur.
# size cells and address cells required if trig-conns node present. # size cells and address cells required if trig-conns node present.
"#size-cells": "#size-cells":
...@@ -129,6 +127,8 @@ properties: ...@@ -129,6 +127,8 @@ properties:
patternProperties: patternProperties:
'^trig-conns@([0-9]+)$': '^trig-conns@([0-9]+)$':
type: object type: object
additionalProperties: false
description: description:
A trigger connections child node which describes the trigger signals A trigger connections child node which describes the trigger signals
between this CTI and another hardware device. This device may be a CPU, between this CTI and another hardware device. This device may be a CPU,
...@@ -140,6 +140,21 @@ patternProperties: ...@@ -140,6 +140,21 @@ patternProperties:
reg: reg:
maxItems: 1 maxItems: 1
cpu:
description:
Handle to cpu this trigger connection is associated with.
arm,cs-dev-assoc:
$ref: /schemas/types.yaml#/definitions/phandle
description:
defines a phandle reference to an associated CoreSight trace device.
When the associated trace device is enabled, then the respective CTI
will be enabled. If the associated device has not been registered
then the node name will be stored as the connection name for later
resolution. If the associated device is not a CoreSight device or
not registered then the node name will remain the connection name
and automatic enabling will not occur.
arm,trig-in-sigs: arm,trig-in-sigs:
$ref: /schemas/types.yaml#/definitions/uint32-array $ref: /schemas/types.yaml#/definitions/uint32-array
minItems: 1 minItems: 1
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment