Commit 712fe4c8 authored by Magnus Damm's avatar Magnus Damm Committed by Greg Kroah-Hartman

serial: sh-sci: Remove BREAK/FRAME/PARITY/OVERRUN printouts

Update the SCIF serial driver to remove printouts for break, frame, parity
and overrun errors. This reduces the amount of console printouts generated
by the defconfig kernel on R-Car Gen3 for certain use cases. To retrieve
more information about such errors the user may inspect counters. Also these
errors are fed into the TTY layer for further application specific handling.
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarMagnus Damm <damm+renesas@opensource.se>
Link: https://lore.kernel.org/r/163884254093.18109.2982470198301927679.sendpatchset@octoSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 46dacba8
...@@ -896,11 +896,9 @@ static void sci_receive_chars(struct uart_port *port) ...@@ -896,11 +896,9 @@ static void sci_receive_chars(struct uart_port *port)
if (status & SCxSR_FER(port)) { if (status & SCxSR_FER(port)) {
flag = TTY_FRAME; flag = TTY_FRAME;
port->icount.frame++; port->icount.frame++;
dev_notice(port->dev, "frame error\n");
} else if (status & SCxSR_PER(port)) { } else if (status & SCxSR_PER(port)) {
flag = TTY_PARITY; flag = TTY_PARITY;
port->icount.parity++; port->icount.parity++;
dev_notice(port->dev, "parity error\n");
} else } else
flag = TTY_NORMAL; flag = TTY_NORMAL;
...@@ -940,8 +938,6 @@ static int sci_handle_errors(struct uart_port *port) ...@@ -940,8 +938,6 @@ static int sci_handle_errors(struct uart_port *port)
/* overrun error */ /* overrun error */
if (tty_insert_flip_char(tport, 0, TTY_OVERRUN)) if (tty_insert_flip_char(tport, 0, TTY_OVERRUN))
copied++; copied++;
dev_notice(port->dev, "overrun error\n");
} }
if (status & SCxSR_FER(port)) { if (status & SCxSR_FER(port)) {
...@@ -950,8 +946,6 @@ static int sci_handle_errors(struct uart_port *port) ...@@ -950,8 +946,6 @@ static int sci_handle_errors(struct uart_port *port)
if (tty_insert_flip_char(tport, 0, TTY_FRAME)) if (tty_insert_flip_char(tport, 0, TTY_FRAME))
copied++; copied++;
dev_notice(port->dev, "frame error\n");
} }
if (status & SCxSR_PER(port)) { if (status & SCxSR_PER(port)) {
...@@ -960,8 +954,6 @@ static int sci_handle_errors(struct uart_port *port) ...@@ -960,8 +954,6 @@ static int sci_handle_errors(struct uart_port *port)
if (tty_insert_flip_char(tport, 0, TTY_PARITY)) if (tty_insert_flip_char(tport, 0, TTY_PARITY))
copied++; copied++;
dev_notice(port->dev, "parity error\n");
} }
if (copied) if (copied)
...@@ -991,8 +983,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port) ...@@ -991,8 +983,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port)
tty_insert_flip_char(tport, 0, TTY_OVERRUN); tty_insert_flip_char(tport, 0, TTY_OVERRUN);
tty_flip_buffer_push(tport); tty_flip_buffer_push(tport);
dev_dbg(port->dev, "overrun error\n");
copied++; copied++;
} }
...@@ -1014,8 +1004,6 @@ static int sci_handle_breaks(struct uart_port *port) ...@@ -1014,8 +1004,6 @@ static int sci_handle_breaks(struct uart_port *port)
/* Notify of BREAK */ /* Notify of BREAK */
if (tty_insert_flip_char(tport, 0, TTY_BREAK)) if (tty_insert_flip_char(tport, 0, TTY_BREAK))
copied++; copied++;
dev_dbg(port->dev, "BREAK detected\n");
} }
if (copied) if (copied)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment