Commit 723d3461 authored by Luca Weiss's avatar Luca Weiss Committed by Bjorn Andersson

soc: qcom: pmic_glink_altmode: Print return value on error

It can be useful to know with which return value for example the
typec_retimer_set call failed, so include this info in the dev_err
prints.
Signed-off-by: default avatarLuca Weiss <luca.weiss@fairphone.com>
Link: https://lore.kernel.org/r/20231017-glink-altmode-ret-v2-1-921aa7cfc381@fairphone.comSigned-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent d79a27ea
...@@ -160,7 +160,7 @@ static void pmic_glink_altmode_enable_dp(struct pmic_glink_altmode *altmode, ...@@ -160,7 +160,7 @@ static void pmic_glink_altmode_enable_dp(struct pmic_glink_altmode *altmode,
ret = typec_mux_set(port->typec_mux, &port->state); ret = typec_mux_set(port->typec_mux, &port->state);
if (ret) if (ret)
dev_err(altmode->dev, "failed to switch mux to DP\n"); dev_err(altmode->dev, "failed to switch mux to DP: %d\n", ret);
port->retimer_state.alt = &port->dp_alt; port->retimer_state.alt = &port->dp_alt;
port->retimer_state.data = &dp_data; port->retimer_state.data = &dp_data;
...@@ -168,7 +168,7 @@ static void pmic_glink_altmode_enable_dp(struct pmic_glink_altmode *altmode, ...@@ -168,7 +168,7 @@ static void pmic_glink_altmode_enable_dp(struct pmic_glink_altmode *altmode,
ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); ret = typec_retimer_set(port->typec_retimer, &port->retimer_state);
if (ret) if (ret)
dev_err(altmode->dev, "failed to setup retimer to DP\n"); dev_err(altmode->dev, "failed to setup retimer to DP: %d\n", ret);
} }
static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode, static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode,
...@@ -182,7 +182,7 @@ static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode, ...@@ -182,7 +182,7 @@ static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode,
ret = typec_mux_set(port->typec_mux, &port->state); ret = typec_mux_set(port->typec_mux, &port->state);
if (ret) if (ret)
dev_err(altmode->dev, "failed to switch mux to USB\n"); dev_err(altmode->dev, "failed to switch mux to USB: %d\n", ret);
port->retimer_state.alt = NULL; port->retimer_state.alt = NULL;
port->retimer_state.data = NULL; port->retimer_state.data = NULL;
...@@ -190,7 +190,7 @@ static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode, ...@@ -190,7 +190,7 @@ static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode,
ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); ret = typec_retimer_set(port->typec_retimer, &port->retimer_state);
if (ret) if (ret)
dev_err(altmode->dev, "failed to setup retimer to USB\n"); dev_err(altmode->dev, "failed to setup retimer to USB: %d\n", ret);
} }
static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode, static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode,
...@@ -204,7 +204,7 @@ static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode, ...@@ -204,7 +204,7 @@ static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode,
ret = typec_mux_set(port->typec_mux, &port->state); ret = typec_mux_set(port->typec_mux, &port->state);
if (ret) if (ret)
dev_err(altmode->dev, "failed to switch mux to safe mode\n"); dev_err(altmode->dev, "failed to switch mux to safe mode: %d\n", ret);
port->retimer_state.alt = NULL; port->retimer_state.alt = NULL;
port->retimer_state.data = NULL; port->retimer_state.data = NULL;
...@@ -212,7 +212,7 @@ static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode, ...@@ -212,7 +212,7 @@ static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode,
ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); ret = typec_retimer_set(port->typec_retimer, &port->retimer_state);
if (ret) if (ret)
dev_err(altmode->dev, "failed to setup retimer to USB\n"); dev_err(altmode->dev, "failed to setup retimer to USB: %d\n", ret);
} }
static void pmic_glink_altmode_worker(struct work_struct *work) static void pmic_glink_altmode_worker(struct work_struct *work)
...@@ -397,7 +397,7 @@ static void pmic_glink_altmode_enable_worker(struct work_struct *work) ...@@ -397,7 +397,7 @@ static void pmic_glink_altmode_enable_worker(struct work_struct *work)
ret = pmic_glink_altmode_request(altmode, ALTMODE_PAN_EN, 0); ret = pmic_glink_altmode_request(altmode, ALTMODE_PAN_EN, 0);
if (ret) if (ret)
dev_err(altmode->dev, "failed to request altmode notifications\n"); dev_err(altmode->dev, "failed to request altmode notifications: %d\n", ret);
} }
static void pmic_glink_altmode_pdr_notify(void *priv, int state) static void pmic_glink_altmode_pdr_notify(void *priv, int state)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment