Commit 7474f23d authored by Julia Lawall's avatar Julia Lawall Committed by Linus Walleij

gpio: max730x: eliminate double free

The function __max730x_remove is called from the remove functions of
drivers/gpio/gpio-max7300.c and drivers/gpio/gpio-max7301.c.  In both
cases, the probe function allocates ts using devm_kzalloc.  Explicitly
freeing such a value with kfree will cause a double free.
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 450fa54c
...@@ -236,7 +236,6 @@ int __max730x_remove(struct device *dev) ...@@ -236,7 +236,6 @@ int __max730x_remove(struct device *dev)
ts->write(dev, 0x04, 0x00); ts->write(dev, 0x04, 0x00);
gpiochip_remove(&ts->chip); gpiochip_remove(&ts->chip);
mutex_destroy(&ts->lock); mutex_destroy(&ts->lock);
kfree(ts);
return 0; return 0;
} }
EXPORT_SYMBOL_GPL(__max730x_remove); EXPORT_SYMBOL_GPL(__max730x_remove);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment