Commit 74dce55c authored by Boris BREZILLON's avatar Boris BREZILLON Committed by Luis Henriques

mtd: mtdpart: fix add_mtd_partitions error path

commit e5bae867 upstream.

If we fail to allocate a partition structure in the middle of the partition
creation process, the already allocated partitions are never removed, which
means they are still present in the partition list and their resources are
never freed.
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent bd6fc7f0
...@@ -637,8 +637,10 @@ int add_mtd_partitions(struct mtd_info *master, ...@@ -637,8 +637,10 @@ int add_mtd_partitions(struct mtd_info *master,
for (i = 0; i < nbparts; i++) { for (i = 0; i < nbparts; i++) {
slave = allocate_partition(master, parts + i, i, cur_offset); slave = allocate_partition(master, parts + i, i, cur_offset);
if (IS_ERR(slave)) if (IS_ERR(slave)) {
del_mtd_partitions(master);
return PTR_ERR(slave); return PTR_ERR(slave);
}
mutex_lock(&mtd_partitions_mutex); mutex_lock(&mtd_partitions_mutex);
list_add(&slave->list, &mtd_partitions); list_add(&slave->list, &mtd_partitions);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment