Commit 758581b9 authored by Dolev Raviv's avatar Dolev Raviv Committed by Christoph Hellwig

scsi: ufs: fix static checker warning in ufshcd_populate_vreg

This patch fixes newly introduced static checker warning in
ufshcd_populate_vreg, introduced by UFS power management series.

Warning:
drivers/scsi/ufs/ufshcd-pltfrm.c:167 ufshcd_populate_vreg()
warn: missing error code here? 'devm_kzalloc()' failed. 'ret' = '0'

To fix it we return -ENOMEM and skip the message print.
Signed-off-by: default avatarDolev Raviv <draviv@codeaurora.org>
Reviewed-by: default avatarMaya Erez <merez@codeaurora.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 233b594b
...@@ -162,10 +162,8 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, ...@@ -162,10 +162,8 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name,
} }
vreg = devm_kzalloc(dev, sizeof(*vreg), GFP_KERNEL); vreg = devm_kzalloc(dev, sizeof(*vreg), GFP_KERNEL);
if (!vreg) { if (!vreg)
dev_err(dev, "No memory for %s regulator\n", name); return -ENOMEM;
goto out;
}
vreg->name = kstrdup(name, GFP_KERNEL); vreg->name = kstrdup(name, GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment