Commit 77b3b30d authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: oti6858.c: remove dbg() tracing calls

dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e79a8a4b
...@@ -211,8 +211,6 @@ static void setup_line(struct work_struct *work) ...@@ -211,8 +211,6 @@ static void setup_line(struct work_struct *work)
unsigned long flags; unsigned long flags;
int result; int result;
dbg("%s(port = %d)", __func__, port->number);
new_setup = kmalloc(OTI6858_CTRL_PKT_SIZE, GFP_KERNEL); new_setup = kmalloc(OTI6858_CTRL_PKT_SIZE, GFP_KERNEL);
if (new_setup == NULL) { if (new_setup == NULL) {
dev_err(&port->dev, "%s(): out of memory!\n", __func__); dev_err(&port->dev, "%s(): out of memory!\n", __func__);
...@@ -282,8 +280,6 @@ static void send_data(struct work_struct *work) ...@@ -282,8 +280,6 @@ static void send_data(struct work_struct *work)
unsigned long flags; unsigned long flags;
u8 *allow; u8 *allow;
dbg("%s(port = %d)", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
if (priv->flags.write_urb_in_use) { if (priv->flags.write_urb_in_use) {
spin_unlock_irqrestore(&priv->lock, flags); spin_unlock_irqrestore(&priv->lock, flags);
...@@ -379,8 +375,6 @@ static int oti6858_startup(struct usb_serial *serial) ...@@ -379,8 +375,6 @@ static int oti6858_startup(struct usb_serial *serial)
static int oti6858_write(struct tty_struct *tty, struct usb_serial_port *port, static int oti6858_write(struct tty_struct *tty, struct usb_serial_port *port,
const unsigned char *buf, int count) const unsigned char *buf, int count)
{ {
dbg("%s(port = %d, count = %d)", __func__, port->number, count);
if (!count) if (!count)
return count; return count;
...@@ -395,8 +389,6 @@ static int oti6858_write_room(struct tty_struct *tty) ...@@ -395,8 +389,6 @@ static int oti6858_write_room(struct tty_struct *tty)
int room = 0; int room = 0;
unsigned long flags; unsigned long flags;
dbg("%s(port = %d)", __func__, port->number);
spin_lock_irqsave(&port->lock, flags); spin_lock_irqsave(&port->lock, flags);
room = kfifo_avail(&port->write_fifo); room = kfifo_avail(&port->write_fifo);
spin_unlock_irqrestore(&port->lock, flags); spin_unlock_irqrestore(&port->lock, flags);
...@@ -410,8 +402,6 @@ static int oti6858_chars_in_buffer(struct tty_struct *tty) ...@@ -410,8 +402,6 @@ static int oti6858_chars_in_buffer(struct tty_struct *tty)
int chars = 0; int chars = 0;
unsigned long flags; unsigned long flags;
dbg("%s(port = %d)", __func__, port->number);
spin_lock_irqsave(&port->lock, flags); spin_lock_irqsave(&port->lock, flags);
chars = kfifo_len(&port->write_fifo); chars = kfifo_len(&port->write_fifo);
spin_unlock_irqrestore(&port->lock, flags); spin_unlock_irqrestore(&port->lock, flags);
...@@ -437,8 +427,6 @@ static void oti6858_set_termios(struct tty_struct *tty, ...@@ -437,8 +427,6 @@ static void oti6858_set_termios(struct tty_struct *tty,
__le16 divisor; __le16 divisor;
int br; int br;
dbg("%s(port = %d)", __func__, port->number);
if (!tty) { if (!tty) {
dbg("%s(): no tty structures", __func__); dbg("%s(): no tty structures", __func__);
return; return;
...@@ -545,8 +533,6 @@ static int oti6858_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -545,8 +533,6 @@ static int oti6858_open(struct tty_struct *tty, struct usb_serial_port *port)
unsigned long flags; unsigned long flags;
int result; int result;
dbg("%s(port = %d)", __func__, port->number);
usb_clear_halt(serial->dev, port->write_urb->pipe); usb_clear_halt(serial->dev, port->write_urb->pipe);
usb_clear_halt(serial->dev, port->read_urb->pipe); usb_clear_halt(serial->dev, port->read_urb->pipe);
...@@ -602,8 +588,6 @@ static void oti6858_close(struct usb_serial_port *port) ...@@ -602,8 +588,6 @@ static void oti6858_close(struct usb_serial_port *port)
struct oti6858_private *priv = usb_get_serial_port_data(port); struct oti6858_private *priv = usb_get_serial_port_data(port);
unsigned long flags; unsigned long flags;
dbg("%s(port = %d)", __func__, port->number);
spin_lock_irqsave(&port->lock, flags); spin_lock_irqsave(&port->lock, flags);
/* clear out any remaining data in the buffer */ /* clear out any remaining data in the buffer */
kfifo_reset_out(&port->write_fifo); kfifo_reset_out(&port->write_fifo);
...@@ -660,8 +644,6 @@ static int oti6858_tiocmget(struct tty_struct *tty) ...@@ -660,8 +644,6 @@ static int oti6858_tiocmget(struct tty_struct *tty)
unsigned pin_state; unsigned pin_state;
unsigned result = 0; unsigned result = 0;
dbg("%s(port = %d)", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
pin_state = priv->status.pin_state & PIN_MASK; pin_state = priv->status.pin_state & PIN_MASK;
spin_unlock_irqrestore(&priv->lock, flags); spin_unlock_irqrestore(&priv->lock, flags);
...@@ -744,8 +726,6 @@ static void oti6858_release(struct usb_serial *serial) ...@@ -744,8 +726,6 @@ static void oti6858_release(struct usb_serial *serial)
{ {
int i; int i;
dbg("%s()", __func__);
for (i = 0; i < serial->num_ports; ++i) for (i = 0; i < serial->num_ports; ++i)
kfree(usb_get_serial_port_data(serial->port[i])); kfree(usb_get_serial_port_data(serial->port[i]));
} }
...@@ -757,9 +737,6 @@ static void oti6858_read_int_callback(struct urb *urb) ...@@ -757,9 +737,6 @@ static void oti6858_read_int_callback(struct urb *urb)
int transient = 0, can_recv = 0, resubmit = 1; int transient = 0, can_recv = 0, resubmit = 1;
int status = urb->status; int status = urb->status;
dbg("%s(port = %d, status = %d)",
__func__, port->number, status);
switch (status) { switch (status) {
case 0: case 0:
/* success */ /* success */
...@@ -876,9 +853,6 @@ static void oti6858_read_bulk_callback(struct urb *urb) ...@@ -876,9 +853,6 @@ static void oti6858_read_bulk_callback(struct urb *urb)
int status = urb->status; int status = urb->status;
int result; int result;
dbg("%s(port = %d, status = %d)",
__func__, port->number, status);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
priv->flags.read_urb_in_use = 0; priv->flags.read_urb_in_use = 0;
spin_unlock_irqrestore(&priv->lock, flags); spin_unlock_irqrestore(&priv->lock, flags);
...@@ -910,9 +884,6 @@ static void oti6858_write_bulk_callback(struct urb *urb) ...@@ -910,9 +884,6 @@ static void oti6858_write_bulk_callback(struct urb *urb)
int status = urb->status; int status = urb->status;
int result; int result;
dbg("%s(port = %d, status = %d)",
__func__, port->number, status);
switch (status) { switch (status) {
case 0: case 0:
/* success */ /* success */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment