Commit 78706121 authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller

ATM-nicstar: Use kmalloc_array() in get_scq()

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2594a2a9
...@@ -871,8 +871,9 @@ static scq_info *get_scq(ns_dev *card, int size, u32 scd) ...@@ -871,8 +871,9 @@ static scq_info *get_scq(ns_dev *card, int size, u32 scd)
kfree(scq); kfree(scq);
return NULL; return NULL;
} }
scq->skb = kmalloc(sizeof(struct sk_buff *) * scq->skb = kmalloc_array(size / NS_SCQE_SIZE,
(size / NS_SCQE_SIZE), GFP_KERNEL); sizeof(*scq->skb),
GFP_KERNEL);
if (!scq->skb) { if (!scq->skb) {
dma_free_coherent(&card->pcidev->dev, dma_free_coherent(&card->pcidev->dev,
2 * size, scq->org, scq->dma); 2 * size, scq->org, scq->dma);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment