Commit 7a401744 authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by Greg Kroah-Hartman

Tools: hv: vssdaemon: report freeze errors

When ioctl(fd, FIFREEZE, 0) results in an error we cannot report it
to syslog instantly since that can cause write to a frozen disk.
However, the name of the filesystem which caused the error and errno
are valuable and we would like to get a nice human-readable message
in the log. Save errno before calling vss_operate(VSS_OP_THAW) and
report the error right after.

Unfortunately, FITHAW errors cannot be reported the same way as we
need to finish thawing all filesystems before calling syslog().

We should also avoid calling endmntent() for the second time in
case we encountered an error during freezing of '/' as it usually
results in SEGSEGV.
Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Acked-by: default avatarDexuan Cui <decui@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8d9560eb
...@@ -82,7 +82,7 @@ static int vss_operate(int operation) ...@@ -82,7 +82,7 @@ static int vss_operate(int operation)
FILE *mounts; FILE *mounts;
struct mntent *ent; struct mntent *ent;
unsigned int cmd; unsigned int cmd;
int error = 0, root_seen = 0; int error = 0, root_seen = 0, save_errno = 0;
switch (operation) { switch (operation) {
case VSS_OP_FREEZE: case VSS_OP_FREEZE:
...@@ -114,7 +114,6 @@ static int vss_operate(int operation) ...@@ -114,7 +114,6 @@ static int vss_operate(int operation)
if (error && operation == VSS_OP_FREEZE) if (error && operation == VSS_OP_FREEZE)
goto err; goto err;
} }
endmntent(mounts);
if (root_seen) { if (root_seen) {
error |= vss_do_freeze("/", cmd); error |= vss_do_freeze("/", cmd);
...@@ -122,10 +121,19 @@ static int vss_operate(int operation) ...@@ -122,10 +121,19 @@ static int vss_operate(int operation)
goto err; goto err;
} }
return error; goto out;
err: err:
endmntent(mounts); save_errno = errno;
vss_operate(VSS_OP_THAW); vss_operate(VSS_OP_THAW);
/* Call syslog after we thaw all filesystems */
if (ent)
syslog(LOG_ERR, "FREEZE of %s failed; error:%d %s",
ent->mnt_dir, save_errno, strerror(save_errno));
else
syslog(LOG_ERR, "FREEZE of / failed; error:%d %s", save_errno,
strerror(save_errno));
out:
endmntent(mounts);
return error; return error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment