Commit 7b01e53e authored by Ido Schimmel's avatar Ido Schimmel Committed by Jakub Kicinski

nexthop: Unlink nexthop group entry in error path

In case of error, remove the nexthop group entry from the list to which
it was previously added.

Fixes: 430a0491 ("nexthop: Add support for nexthop groups")
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 07e61a97
...@@ -1459,8 +1459,10 @@ static struct nexthop *nexthop_create_group(struct net *net, ...@@ -1459,8 +1459,10 @@ static struct nexthop *nexthop_create_group(struct net *net,
return nh; return nh;
out_no_nh: out_no_nh:
for (i--; i >= 0; --i) for (i--; i >= 0; --i) {
list_del(&nhg->nh_entries[i].nh_list);
nexthop_put(nhg->nh_entries[i].nh); nexthop_put(nhg->nh_entries[i].nh);
}
kfree(nhg->spare); kfree(nhg->spare);
kfree(nhg); kfree(nhg);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment