Commit 7b69ef62 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jarkko Sakkinen

tpm/tpm_tis_synquacer: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
parent c3da2c6e
...@@ -127,14 +127,12 @@ static int tpm_tis_synquacer_probe(struct platform_device *pdev) ...@@ -127,14 +127,12 @@ static int tpm_tis_synquacer_probe(struct platform_device *pdev)
return tpm_tis_synquacer_init(&pdev->dev, &tpm_info); return tpm_tis_synquacer_init(&pdev->dev, &tpm_info);
} }
static int tpm_tis_synquacer_remove(struct platform_device *pdev) static void tpm_tis_synquacer_remove(struct platform_device *pdev)
{ {
struct tpm_chip *chip = dev_get_drvdata(&pdev->dev); struct tpm_chip *chip = dev_get_drvdata(&pdev->dev);
tpm_chip_unregister(chip); tpm_chip_unregister(chip);
tpm_tis_remove(chip); tpm_tis_remove(chip);
return 0;
} }
#ifdef CONFIG_OF #ifdef CONFIG_OF
...@@ -155,7 +153,7 @@ MODULE_DEVICE_TABLE(acpi, tpm_synquacer_acpi_tbl); ...@@ -155,7 +153,7 @@ MODULE_DEVICE_TABLE(acpi, tpm_synquacer_acpi_tbl);
static struct platform_driver tis_synquacer_drv = { static struct platform_driver tis_synquacer_drv = {
.probe = tpm_tis_synquacer_probe, .probe = tpm_tis_synquacer_probe,
.remove = tpm_tis_synquacer_remove, .remove_new = tpm_tis_synquacer_remove,
.driver = { .driver = {
.name = "tpm_tis_synquacer", .name = "tpm_tis_synquacer",
.pm = &tpm_tis_synquacer_pm, .pm = &tpm_tis_synquacer_pm,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment