Commit 7daac5b2 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Petr Mladek

lib/vsprintf: Print time64_t in human readable format

There are users which print time and date represented by content of
time64_t type in human readable format.

Instead of open coding that each time introduce %ptT[dt][r] specifier.

Few test cases for %ptT specifier has been added as well.

Link: https://lore.kernel.org/r/20200415170046.33374-2-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Rewieved-by: default avatarPetr Mladek <pmladek@suse.com>
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
parent 8f3d9f35
...@@ -468,21 +468,23 @@ Examples (OF):: ...@@ -468,21 +468,23 @@ Examples (OF)::
%pfwf /ocp@68000000/i2c@48072000/camera@10/port/endpoint - Full name %pfwf /ocp@68000000/i2c@48072000/camera@10/port/endpoint - Full name
%pfwP endpoint - Node name %pfwP endpoint - Node name
Time and date (struct rtc_time) Time and date
------------------------------- -------------
:: ::
%ptR YYYY-mm-ddTHH:MM:SS %pt[RT] YYYY-mm-ddTHH:MM:SS
%ptRd YYYY-mm-dd %pt[RT]d YYYY-mm-dd
%ptRt HH:MM:SS %pt[RT]t HH:MM:SS
%ptR[dt][r] %pt[RT][dt][r]
For printing date and time as represented by struct rtc_time structure in For printing date and time as represented by
human readable format. R struct rtc_time structure
T time64_t type
in human readable format.
By default year will be incremented by 1900 and month by 1. Use %ptRr (raw) By default year will be incremented by 1900 and month by 1.
to suppress this behaviour. Use %pt[RT]r (raw) to suppress this behaviour.
Passed by reference. Passed by reference.
......
...@@ -478,7 +478,7 @@ struct_va_format(void) ...@@ -478,7 +478,7 @@ struct_va_format(void)
} }
static void __init static void __init
struct_rtc_time(void) time_and_date(void)
{ {
/* 1543210543 */ /* 1543210543 */
const struct rtc_time tm = { const struct rtc_time tm = {
...@@ -489,14 +489,21 @@ struct_rtc_time(void) ...@@ -489,14 +489,21 @@ struct_rtc_time(void)
.tm_mon = 10, .tm_mon = 10,
.tm_year = 118, .tm_year = 118,
}; };
/* 2019-01-04T15:32:23 */
time64_t t = 1546615943;
test("(%ptR?)", "%pt", &tm); test("(%pt?)", "%pt", &tm);
test("2018-11-26T05:35:43", "%ptR", &tm); test("2018-11-26T05:35:43", "%ptR", &tm);
test("0118-10-26T05:35:43", "%ptRr", &tm); test("0118-10-26T05:35:43", "%ptRr", &tm);
test("05:35:43|2018-11-26", "%ptRt|%ptRd", &tm, &tm); test("05:35:43|2018-11-26", "%ptRt|%ptRd", &tm, &tm);
test("05:35:43|0118-10-26", "%ptRtr|%ptRdr", &tm, &tm); test("05:35:43|0118-10-26", "%ptRtr|%ptRdr", &tm, &tm);
test("05:35:43|2018-11-26", "%ptRttr|%ptRdtr", &tm, &tm); test("05:35:43|2018-11-26", "%ptRttr|%ptRdtr", &tm, &tm);
test("05:35:43 tr|2018-11-26 tr", "%ptRt tr|%ptRd tr", &tm, &tm); test("05:35:43 tr|2018-11-26 tr", "%ptRt tr|%ptRd tr", &tm, &tm);
test("2019-01-04T15:32:23", "%ptT", &t);
test("0119-00-04T15:32:23", "%ptTr", &t);
test("15:32:23|2019-01-04", "%ptTt|%ptTd", &t, &t);
test("15:32:23|0119-00-04", "%ptTtr|%ptTdr", &t, &t);
} }
static void __init static void __init
...@@ -661,7 +668,7 @@ test_pointer(void) ...@@ -661,7 +668,7 @@ test_pointer(void)
uuid(); uuid();
dentry(); dentry();
struct_va_format(); struct_va_format();
struct_rtc_time(); time_and_date();
struct_clk(); struct_clk();
bitmap(); bitmap();
netdev_features(); netdev_features();
......
...@@ -34,6 +34,7 @@ ...@@ -34,6 +34,7 @@
#include <linux/dcache.h> #include <linux/dcache.h>
#include <linux/cred.h> #include <linux/cred.h>
#include <linux/rtc.h> #include <linux/rtc.h>
#include <linux/time.h>
#include <linux/uuid.h> #include <linux/uuid.h>
#include <linux/of.h> #include <linux/of.h>
#include <net/addrconf.h> #include <net/addrconf.h>
...@@ -1819,6 +1820,29 @@ char *rtc_str(char *buf, char *end, const struct rtc_time *tm, ...@@ -1819,6 +1820,29 @@ char *rtc_str(char *buf, char *end, const struct rtc_time *tm,
return buf; return buf;
} }
static noinline_for_stack
char *time64_str(char *buf, char *end, const time64_t time,
struct printf_spec spec, const char *fmt)
{
struct rtc_time rtc_time;
struct tm tm;
time64_to_tm(time, 0, &tm);
rtc_time.tm_sec = tm.tm_sec;
rtc_time.tm_min = tm.tm_min;
rtc_time.tm_hour = tm.tm_hour;
rtc_time.tm_mday = tm.tm_mday;
rtc_time.tm_mon = tm.tm_mon;
rtc_time.tm_year = tm.tm_year;
rtc_time.tm_wday = tm.tm_wday;
rtc_time.tm_yday = tm.tm_yday;
rtc_time.tm_isdst = 0;
return rtc_str(buf, end, &rtc_time, spec, fmt);
}
static noinline_for_stack static noinline_for_stack
char *time_and_date(char *buf, char *end, void *ptr, struct printf_spec spec, char *time_and_date(char *buf, char *end, void *ptr, struct printf_spec spec,
const char *fmt) const char *fmt)
...@@ -1826,8 +1850,10 @@ char *time_and_date(char *buf, char *end, void *ptr, struct printf_spec spec, ...@@ -1826,8 +1850,10 @@ char *time_and_date(char *buf, char *end, void *ptr, struct printf_spec spec,
switch (fmt[1]) { switch (fmt[1]) {
case 'R': case 'R':
return rtc_str(buf, end, (const struct rtc_time *)ptr, spec, fmt); return rtc_str(buf, end, (const struct rtc_time *)ptr, spec, fmt);
case 'T':
return time64_str(buf, end, *(const time64_t *)ptr, spec, fmt);
default: default:
return error_string(buf, end, "(%ptR?)", spec); return error_string(buf, end, "(%pt?)", spec);
} }
} }
...@@ -2143,8 +2169,9 @@ char *fwnode_string(char *buf, char *end, struct fwnode_handle *fwnode, ...@@ -2143,8 +2169,9 @@ char *fwnode_string(char *buf, char *end, struct fwnode_handle *fwnode,
* - 'd[234]' For a dentry name (optionally 2-4 last components) * - 'd[234]' For a dentry name (optionally 2-4 last components)
* - 'D[234]' Same as 'd' but for a struct file * - 'D[234]' Same as 'd' but for a struct file
* - 'g' For block_device name (gendisk + partition number) * - 'g' For block_device name (gendisk + partition number)
* - 't[R][dt][r]' For time and date as represented: * - 't[RT][dt][r]' For time and date as represented by:
* R struct rtc_time * R struct rtc_time
* T time64_t
* - 'C' For a clock, it prints the name (Common Clock Framework) or address * - 'C' For a clock, it prints the name (Common Clock Framework) or address
* (legacy clock framework) of the clock * (legacy clock framework) of the clock
* - 'Cn' For a clock, it prints the name (Common Clock Framework) or address * - 'Cn' For a clock, it prints the name (Common Clock Framework) or address
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment