Commit 808e657c authored by Michael Opdenacker's avatar Michael Opdenacker Committed by Linus Walleij

pinctrl: remove minor dead code

This removes a test whether the 'desc' variable is NULL.
This possibility has already been eliminated by the
below test earlier in the loop:

                if (desc == NULL) {
                        dev_warn(pctldev->dev,
                                 "could not get pin desc for pin %d\n",
                                 pins[i]);
                        continue;
                }

Found with Coverity: CID #1090078
Signed-off-by: default avatarMichael Opdenacker <michael.opdenacker@free-electrons.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a3183c60
...@@ -505,16 +505,14 @@ void pinmux_disable_setting(struct pinctrl_setting const *setting) ...@@ -505,16 +505,14 @@ void pinmux_disable_setting(struct pinctrl_setting const *setting)
pin_free(pctldev, pins[i], NULL); pin_free(pctldev, pins[i], NULL);
} else { } else {
const char *gname; const char *gname;
const char *pname;
pname = desc ? desc->name : "non-existing";
gname = pctlops->get_group_name(pctldev, gname = pctlops->get_group_name(pctldev,
setting->data.mux.group); setting->data.mux.group);
dev_warn(pctldev->dev, dev_warn(pctldev->dev,
"not freeing pin %d (%s) as part of " "not freeing pin %d (%s) as part of "
"deactivating group %s - it is already " "deactivating group %s - it is already "
"used for some other setting", "used for some other setting",
pins[i], pname, gname); pins[i], desc->name, gname);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment