Commit 824deff8 authored by Rostislav Pehlivanov's avatar Rostislav Pehlivanov Committed by Jiri Kosina

HID: sony: Fix DS4 controller reporting rate issues

This commit removes the cap on the DualShock 4 controller reporting rate when
connected using Bluetooth. The previous value of '0xB0' capped the rate to only
20.83 Hz which many userspace utilities mistook as a sign of a bad signal.
Since a 'B' and an '8' can look similar it's possible that someone mistook the
one for another.  The new value of '0x80' enables the full 1000 Hz peak
reporting rate that the controller is capable of.

Frank adds: "Back when the original code was written the purpose of that value
was unknown and 0xB0 seemed to work so that's what ended up being used.  Now
that we know what it actually does and that 0x80 is a better choice I support
this patch."

[jkosina@suse.com: update changelog]
Signed-off-by: default avatarRostislav Pehlivanov <atomnuker@gmail.com>
Acked-by: default avatarFrank Praznik <frank.praznik@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 8f5f0bc2
...@@ -1854,7 +1854,7 @@ static void dualshock4_state_worker(struct work_struct *work) ...@@ -1854,7 +1854,7 @@ static void dualshock4_state_worker(struct work_struct *work)
} else { } else {
memset(buf, 0, DS4_REPORT_0x11_SIZE); memset(buf, 0, DS4_REPORT_0x11_SIZE);
buf[0] = 0x11; buf[0] = 0x11;
buf[1] = 0xB0; buf[1] = 0x80;
buf[3] = 0x0F; buf[3] = 0x0F;
offset = 6; offset = 6;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment