Commit 8378a51e authored by Ronnie Sahlberg's avatar Ronnie Sahlberg Committed by Steve French

cifs: fix potential double free during failed mount

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=2088799

Cc: stable@vger.kernel.org
Signed-off-by: default avatarRoberto Bergantinos <rbergant@redhat.com>
Signed-off-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent bf272460
...@@ -838,7 +838,7 @@ cifs_smb3_do_mount(struct file_system_type *fs_type, ...@@ -838,7 +838,7 @@ cifs_smb3_do_mount(struct file_system_type *fs_type,
int flags, struct smb3_fs_context *old_ctx) int flags, struct smb3_fs_context *old_ctx)
{ {
int rc; int rc;
struct super_block *sb; struct super_block *sb = NULL;
struct cifs_sb_info *cifs_sb = NULL; struct cifs_sb_info *cifs_sb = NULL;
struct cifs_mnt_data mnt_data; struct cifs_mnt_data mnt_data;
struct dentry *root; struct dentry *root;
...@@ -934,10 +934,12 @@ cifs_smb3_do_mount(struct file_system_type *fs_type, ...@@ -934,10 +934,12 @@ cifs_smb3_do_mount(struct file_system_type *fs_type,
return root; return root;
out: out:
if (cifs_sb) { if (cifs_sb) {
if (!sb || IS_ERR(sb)) { /* otherwise kill_sb will handle */
kfree(cifs_sb->prepath); kfree(cifs_sb->prepath);
smb3_cleanup_fs_context(cifs_sb->ctx); smb3_cleanup_fs_context(cifs_sb->ctx);
kfree(cifs_sb); kfree(cifs_sb);
} }
}
return root; return root;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment