Commit 83ff9318 authored by Coly Li's avatar Coly Li Committed by Jens Axboe

bcache: not use hard coded memset size in bch_cache_accounting_clear()

In stats.c:bch_cache_accounting_clear(), a hard coded number '7' is
used in memset(). It is because in struct cache_stats, there are 7
atomic_t type members. This is not good when new members added into
struct stats, the hard coded number will only clear part of memory.

This patch replaces 'sizeof(unsigned long) * 7' by more generic
'sizeof(struct cache_stats))', to avoid potential error if new
member added into struct cache_stats.
Signed-off-by: default avatarColy Li <colyli@suse.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9951379b
...@@ -111,7 +111,7 @@ void bch_cache_accounting_clear(struct cache_accounting *acc) ...@@ -111,7 +111,7 @@ void bch_cache_accounting_clear(struct cache_accounting *acc)
{ {
memset(&acc->total.cache_hits, memset(&acc->total.cache_hits,
0, 0,
sizeof(unsigned long) * 7); sizeof(struct cache_stats));
} }
void bch_cache_accounting_destroy(struct cache_accounting *acc) void bch_cache_accounting_destroy(struct cache_accounting *acc)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment