Commit 85ba94ba authored by Matt Mackall's avatar Matt Mackall Committed by Linus Torvalds

SLOB: fix bogus ksize calculation

SLOB's ksize calculation was braindamaged and generally harmlessly
underreported the allocation size. But for very small buffers, it could
in fact overreport them, leading code depending on krealloc to overrun
the allocation and trample other data.
Signed-off-by: default avatarMatt Mackall <mpm@selenic.com>
Tested-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e09e6e2b
...@@ -515,7 +515,7 @@ size_t ksize(const void *block) ...@@ -515,7 +515,7 @@ size_t ksize(const void *block)
sp = (struct slob_page *)virt_to_page(block); sp = (struct slob_page *)virt_to_page(block);
if (slob_page(sp)) if (slob_page(sp))
return ((slob_t *)block - 1)->units + SLOB_UNIT; return (((slob_t *)block - 1)->units - 1) * SLOB_UNIT;
else else
return sp->page.private; return sp->page.private;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment