Commit 85d0f7fa authored by Alan Stern's avatar Alan Stern Committed by Greg Kroah-Hartman

[PATCH] USB: Eliminate dead code from the UHCI driver

I'm not sure what this piece of code is doing in the UHCI driver.  It
looks like someone envisioned queuing several URBs for the same endpoint
simultaneously.  Anyway, the driver can't do that and this code can never
run.
parent 44fedd70
...@@ -332,17 +332,7 @@ static void uhci_insert_qh(struct uhci_hcd *uhci, struct uhci_qh *skelqh, struct ...@@ -332,17 +332,7 @@ static void uhci_insert_qh(struct uhci_hcd *uhci, struct uhci_qh *skelqh, struct
/* Grab the last QH */ /* Grab the last QH */
lqh = list_entry(skelqh->list.prev, struct uhci_qh, list); lqh = list_entry(skelqh->list.prev, struct uhci_qh, list);
/* /* Point to the next skelqh */
* Patch this endpoint's URB's QHs to point to the next skelqh:
* skelqh --> ... lqh --> newqh --> next skelqh
* Do this first, so the HC always sees the right QH after this one.
*/
list_for_each (tmp, &urbp->queue_list) {
struct urb_priv *turbp =
list_entry(tmp, struct urb_priv, queue_list);
turbp->qh->link = lqh->link;
}
urbp->qh->link = lqh->link; urbp->qh->link = lqh->link;
wmb(); /* Ordering is important */ wmb(); /* Ordering is important */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment