Commit 86f8515f authored by Daniel Borkmann's avatar Daniel Borkmann Committed by Pablo Neira Ayuso

net: netprio: rename config to be more consistent with cgroup configs

While we're at it and introduced CGROUP_NET_CLASSID, lets also make
NETPRIO_CGROUP more consistent with the rest of cgroups and rename it
into CONFIG_CGROUP_NET_PRIO so that for networking, we now have
CONFIG_CGROUP_NET_{PRIO,CLASSID}. This not only makes the CONFIG
option consistent among networking cgroups, but also among cgroups
CONFIG conventions in general as the vast majority has a prefix of
CONFIG_CGROUP_<SUBSYS>.
Signed-off-by: default avatarDaniel Borkmann <dborkman@redhat.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: cgroups@vger.kernel.org
Acked-by: default avatarLi Zefan <lizefan@huawei.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent fe1217c4
...@@ -43,7 +43,7 @@ SUBSYS(blkio) ...@@ -43,7 +43,7 @@ SUBSYS(blkio)
SUBSYS(perf) SUBSYS(perf)
#endif #endif
#if IS_SUBSYS_ENABLED(CONFIG_NETPRIO_CGROUP) #if IS_SUBSYS_ENABLED(CONFIG_CGROUP_NET_PRIO)
SUBSYS(net_prio) SUBSYS(net_prio)
#endif #endif
......
...@@ -1444,7 +1444,7 @@ struct net_device { ...@@ -1444,7 +1444,7 @@ struct net_device {
/* max exchange id for FCoE LRO by ddp */ /* max exchange id for FCoE LRO by ddp */
unsigned int fcoe_ddp_xid; unsigned int fcoe_ddp_xid;
#endif #endif
#if IS_ENABLED(CONFIG_NETPRIO_CGROUP) #if IS_ENABLED(CONFIG_CGROUP_NET_PRIO)
struct netprio_map __rcu *priomap; struct netprio_map __rcu *priomap;
#endif #endif
/* phy device may attach itself for hardware timestamping */ /* phy device may attach itself for hardware timestamping */
......
...@@ -13,12 +13,12 @@ ...@@ -13,12 +13,12 @@
#ifndef _NETPRIO_CGROUP_H #ifndef _NETPRIO_CGROUP_H
#define _NETPRIO_CGROUP_H #define _NETPRIO_CGROUP_H
#include <linux/cgroup.h> #include <linux/cgroup.h>
#include <linux/hardirq.h> #include <linux/hardirq.h>
#include <linux/rcupdate.h> #include <linux/rcupdate.h>
#if IS_ENABLED(CONFIG_CGROUP_NET_PRIO)
#if IS_ENABLED(CONFIG_NETPRIO_CGROUP)
struct netprio_map { struct netprio_map {
struct rcu_head rcu; struct rcu_head rcu;
u32 priomap_len; u32 priomap_len;
...@@ -27,8 +27,7 @@ struct netprio_map { ...@@ -27,8 +27,7 @@ struct netprio_map {
void sock_update_netprioidx(struct sock *sk); void sock_update_netprioidx(struct sock *sk);
#if IS_BUILTIN(CONFIG_NETPRIO_CGROUP) #if IS_BUILTIN(CONFIG_CGROUP_NET_PRIO)
static inline u32 task_netprioidx(struct task_struct *p) static inline u32 task_netprioidx(struct task_struct *p)
{ {
struct cgroup_subsys_state *css; struct cgroup_subsys_state *css;
...@@ -40,9 +39,7 @@ static inline u32 task_netprioidx(struct task_struct *p) ...@@ -40,9 +39,7 @@ static inline u32 task_netprioidx(struct task_struct *p)
rcu_read_unlock(); rcu_read_unlock();
return idx; return idx;
} }
#elif IS_MODULE(CONFIG_CGROUP_NET_PRIO)
#elif IS_MODULE(CONFIG_NETPRIO_CGROUP)
static inline u32 task_netprioidx(struct task_struct *p) static inline u32 task_netprioidx(struct task_struct *p)
{ {
struct cgroup_subsys_state *css; struct cgroup_subsys_state *css;
...@@ -56,9 +53,7 @@ static inline u32 task_netprioidx(struct task_struct *p) ...@@ -56,9 +53,7 @@ static inline u32 task_netprioidx(struct task_struct *p)
return idx; return idx;
} }
#endif #endif
#else /* !CONFIG_CGROUP_NET_PRIO */
#else /* !CONFIG_NETPRIO_CGROUP */
static inline u32 task_netprioidx(struct task_struct *p) static inline u32 task_netprioidx(struct task_struct *p)
{ {
return 0; return 0;
...@@ -66,6 +61,5 @@ static inline u32 task_netprioidx(struct task_struct *p) ...@@ -66,6 +61,5 @@ static inline u32 task_netprioidx(struct task_struct *p)
#define sock_update_netprioidx(sk) #define sock_update_netprioidx(sk)
#endif /* CONFIG_NETPRIO_CGROUP */ #endif /* CONFIG_CGROUP_NET_PRIO */
#endif /* _NET_CLS_CGROUP_H */ #endif /* _NET_CLS_CGROUP_H */
...@@ -395,7 +395,7 @@ struct sock { ...@@ -395,7 +395,7 @@ struct sock {
unsigned short sk_ack_backlog; unsigned short sk_ack_backlog;
unsigned short sk_max_ack_backlog; unsigned short sk_max_ack_backlog;
__u32 sk_priority; __u32 sk_priority;
#if IS_ENABLED(CONFIG_NETPRIO_CGROUP) #if IS_ENABLED(CONFIG_CGROUP_NET_PRIO)
__u32 sk_cgrp_prioidx; __u32 sk_cgrp_prioidx;
#endif #endif
struct pid *sk_peer_pid; struct pid *sk_peer_pid;
......
...@@ -238,12 +238,12 @@ config XPS ...@@ -238,12 +238,12 @@ config XPS
depends on SMP depends on SMP
default y default y
config NETPRIO_CGROUP config CGROUP_NET_PRIO
tristate "Network priority cgroup" tristate "Network priority cgroup"
depends on CGROUPS depends on CGROUPS
---help--- ---help---
Cgroup subsystem for use in assigning processes to network priorities on Cgroup subsystem for use in assigning processes to network priorities on
a per-interface basis a per-interface basis.
config CGROUP_NET_CLASSID config CGROUP_NET_CLASSID
boolean "Network classid cgroup" boolean "Network classid cgroup"
......
...@@ -21,5 +21,5 @@ obj-$(CONFIG_FIB_RULES) += fib_rules.o ...@@ -21,5 +21,5 @@ obj-$(CONFIG_FIB_RULES) += fib_rules.o
obj-$(CONFIG_TRACEPOINTS) += net-traces.o obj-$(CONFIG_TRACEPOINTS) += net-traces.o
obj-$(CONFIG_NET_DROP_MONITOR) += drop_monitor.o obj-$(CONFIG_NET_DROP_MONITOR) += drop_monitor.o
obj-$(CONFIG_NETWORK_PHY_TIMESTAMPING) += timestamping.o obj-$(CONFIG_NETWORK_PHY_TIMESTAMPING) += timestamping.o
obj-$(CONFIG_NETPRIO_CGROUP) += netprio_cgroup.o obj-$(CONFIG_CGROUP_NET_PRIO) += netprio_cgroup.o
obj-$(CONFIG_CGROUP_NET_CLASSID) += netclassid_cgroup.o obj-$(CONFIG_CGROUP_NET_CLASSID) += netclassid_cgroup.o
...@@ -2747,7 +2747,7 @@ static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q, ...@@ -2747,7 +2747,7 @@ static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q,
return rc; return rc;
} }
#if IS_ENABLED(CONFIG_NETPRIO_CGROUP) #if IS_ENABLED(CONFIG_CGROUP_NET_PRIO)
static void skb_update_prio(struct sk_buff *skb) static void skb_update_prio(struct sk_buff *skb)
{ {
struct netprio_map *map = rcu_dereference_bh(skb->dev->priomap); struct netprio_map *map = rcu_dereference_bh(skb->dev->priomap);
......
...@@ -1308,7 +1308,7 @@ static void sk_prot_free(struct proto *prot, struct sock *sk) ...@@ -1308,7 +1308,7 @@ static void sk_prot_free(struct proto *prot, struct sock *sk)
module_put(owner); module_put(owner);
} }
#if IS_ENABLED(CONFIG_NETPRIO_CGROUP) #if IS_ENABLED(CONFIG_CGROUP_NET_PRIO)
void sock_update_netprioidx(struct sock *sk) void sock_update_netprioidx(struct sock *sk)
{ {
if (in_interrupt()) if (in_interrupt())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment