Commit 876e956f authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

drivers/net: drop redundant memset

The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
  memcpy(e1,e4,e3);
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 255f5c32
...@@ -5819,10 +5819,8 @@ static void s2io_vpd_read(struct s2io_nic *nic) ...@@ -5819,10 +5819,8 @@ static void s2io_vpd_read(struct s2io_nic *nic)
} }
} }
if ((!fail) && (vpd_data[1] < VPD_STRING_LEN)) { if ((!fail) && (vpd_data[1] < VPD_STRING_LEN))
memset(nic->product_name, 0, vpd_data[1]);
memcpy(nic->product_name, &vpd_data[3], vpd_data[1]); memcpy(nic->product_name, &vpd_data[3], vpd_data[1]);
}
kfree(vpd_data); kfree(vpd_data);
swstats->mem_freed += 256; swstats->mem_freed += 256;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment