Commit 88b7381a authored by Bastien Nocera's avatar Bastien Nocera Committed by Greg Kroah-Hartman

USB: Select better matching USB drivers when available

Now that USB device drivers can reuse code from the generic USB device
driver, we need to make sure that they get selected rather than the
generic driver. Add an id_table and match vfunc to the usb_device_driver
struct, which will get used to select a better matching driver at
->probe time.

This is a similar mechanism to that used in the HID drivers, with the
generic driver being selected unless there's a better matching one found
in the registered drivers (see hid_generic_match() in
drivers/hid/hid-generic.c).
Signed-off-by: default avatarBastien Nocera <hadess@hadess.net>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20191016093933.693-5-hadess@hadess.netSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aeebf2b5
...@@ -818,13 +818,24 @@ static int usb_device_match(struct device *dev, struct device_driver *drv) ...@@ -818,13 +818,24 @@ static int usb_device_match(struct device *dev, struct device_driver *drv)
{ {
/* devices and interfaces are handled separately */ /* devices and interfaces are handled separately */
if (is_usb_device(dev)) { if (is_usb_device(dev)) {
struct usb_device *udev;
struct usb_device_driver *udrv;
/* interface drivers never match devices */ /* interface drivers never match devices */
if (!is_usb_device_driver(drv)) if (!is_usb_device_driver(drv))
return 0; return 0;
/* TODO: Add real matching code */ udev = to_usb_device(dev);
udrv = to_usb_device_driver(drv);
if (udrv->id_table &&
usb_device_match_id(udev, udrv->id_table) != NULL) {
return 1; return 1;
}
if (udrv->match)
return udrv->match(udev);
return 0;
} else if (is_usb_interface(dev)) { } else if (is_usb_interface(dev)) {
struct usb_interface *intf; struct usb_interface *intf;
......
...@@ -195,6 +195,34 @@ int usb_choose_configuration(struct usb_device *udev) ...@@ -195,6 +195,34 @@ int usb_choose_configuration(struct usb_device *udev)
} }
EXPORT_SYMBOL_GPL(usb_choose_configuration); EXPORT_SYMBOL_GPL(usb_choose_configuration);
static int __check_usb_generic(struct device_driver *drv, void *data)
{
struct usb_device *udev = data;
struct usb_device_driver *udrv;
if (!is_usb_device_driver(drv))
return 0;
udrv = to_usb_device_driver(drv);
if (udrv == &usb_generic_driver)
return 0;
if (!udrv->id_table)
return 0;
return usb_device_match_id(udev, udrv->id_table) != NULL;
}
static bool usb_generic_driver_match(struct usb_device *udev)
{
/*
* If any other driver wants the device, leave the device to this other
* driver.
*/
if (bus_for_each_drv(&usb_bus_type, NULL, udev, __check_usb_generic))
return false;
return true;
}
int usb_generic_driver_probe(struct usb_device *udev) int usb_generic_driver_probe(struct usb_device *udev)
{ {
int err, c; int err, c;
...@@ -285,6 +313,7 @@ int usb_generic_driver_resume(struct usb_device *udev, pm_message_t msg) ...@@ -285,6 +313,7 @@ int usb_generic_driver_resume(struct usb_device *udev, pm_message_t msg)
struct usb_device_driver usb_generic_driver = { struct usb_device_driver usb_generic_driver = {
.name = "usb", .name = "usb",
.match = usb_generic_driver_match,
.probe = usb_generic_driver_probe, .probe = usb_generic_driver_probe,
.disconnect = usb_generic_driver_disconnect, .disconnect = usb_generic_driver_disconnect,
#ifdef CONFIG_PM #ifdef CONFIG_PM
......
...@@ -1237,6 +1237,7 @@ struct usb_driver { ...@@ -1237,6 +1237,7 @@ struct usb_driver {
struct usb_device_driver { struct usb_device_driver {
const char *name; const char *name;
bool (*match) (struct usb_device *udev);
int (*probe) (struct usb_device *udev); int (*probe) (struct usb_device *udev);
void (*disconnect) (struct usb_device *udev); void (*disconnect) (struct usb_device *udev);
...@@ -1244,6 +1245,7 @@ struct usb_device_driver { ...@@ -1244,6 +1245,7 @@ struct usb_device_driver {
int (*resume) (struct usb_device *udev, pm_message_t message); int (*resume) (struct usb_device *udev, pm_message_t message);
const struct attribute_group **dev_groups; const struct attribute_group **dev_groups;
struct usbdrv_wrap drvwrap; struct usbdrv_wrap drvwrap;
const struct usb_device_id *id_table;
unsigned int supports_autosuspend:1; unsigned int supports_autosuspend:1;
unsigned int generic_subclass:1; unsigned int generic_subclass:1;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment