Commit 8a323526 authored by Maciej W. Rozycki's avatar Maciej W. Rozycki Committed by Jeff Garzik

defxx: Fix the handling of ioremap() failures

 If ioremap_nocache() is unfortunate enough to fail, the error code is not
set correctly leading to a false success from dfx_register().  This change
fixes the problem.
Signed-off-by: default avatarMaciej W. Rozycki <macro@linux-mips.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 34dd962b
...@@ -566,6 +566,7 @@ static int __devinit dfx_register(struct device *bdev) ...@@ -566,6 +566,7 @@ static int __devinit dfx_register(struct device *bdev)
bp->base.mem = ioremap_nocache(bar_start, bar_len); bp->base.mem = ioremap_nocache(bar_start, bar_len);
if (!bp->base.mem) { if (!bp->base.mem) {
printk(KERN_ERR "%s: Cannot map MMIO\n", print_name); printk(KERN_ERR "%s: Cannot map MMIO\n", print_name);
err = -ENOMEM;
goto err_out_region; goto err_out_region;
} }
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment