Commit 8c39a39e authored by Trond Myklebust's avatar Trond Myklebust

NFSv4: Fix a credential refcount leak in nfs41_check_delegation_stateid

It is unsafe to dereference delegation outside the rcu lock, and in
any case, the refcount is guaranteed held if cred is non-zero.
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent e21a712a
...@@ -2778,7 +2778,6 @@ static void nfs41_check_delegation_stateid(struct nfs4_state *state) ...@@ -2778,7 +2778,6 @@ static void nfs41_check_delegation_stateid(struct nfs4_state *state)
if (status == -NFS4ERR_EXPIRED || status == -NFS4ERR_BAD_STATEID) if (status == -NFS4ERR_EXPIRED || status == -NFS4ERR_BAD_STATEID)
nfs_finish_clear_delegation_stateid(state, &stateid); nfs_finish_clear_delegation_stateid(state, &stateid);
if (delegation->cred)
put_cred(cred); put_cred(cred);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment