Commit 8e2ea3ea authored by Michal Kalderon's avatar Michal Kalderon Committed by David S. Miller

qed: Fix static checker warning

In some cases abs_ppfid could be printed without being initialized.

Fixes: 79284ade ("qed: Add llh ppfid interface and 100g support for offload protocols")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMichal Kalderon <michal.kalderon@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e70c7aad
...@@ -1138,12 +1138,12 @@ qed_llh_add_protocol_filter(struct qed_dev *cdev, ...@@ -1138,12 +1138,12 @@ qed_llh_add_protocol_filter(struct qed_dev *cdev,
if (rc) if (rc)
goto err; goto err;
/* Configure the LLH only in case of a new the filter */
if (ref_cnt == 1) {
rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid); rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid);
if (rc) if (rc)
goto err; goto err;
/* Configure the LLH only in case of a new the filter */
if (ref_cnt == 1) {
rc = qed_llh_protocol_filter_to_hilo(cdev, type, rc = qed_llh_protocol_filter_to_hilo(cdev, type,
source_port_or_eth_type, source_port_or_eth_type,
dest_port, &high, &low); dest_port, &high, &low);
...@@ -1195,12 +1195,12 @@ void qed_llh_remove_mac_filter(struct qed_dev *cdev, ...@@ -1195,12 +1195,12 @@ void qed_llh_remove_mac_filter(struct qed_dev *cdev,
if (rc) if (rc)
goto err; goto err;
/* Remove from the LLH in case the filter is not in use */
if (!ref_cnt) {
rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid); rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid);
if (rc) if (rc)
goto err; goto err;
/* Remove from the LLH in case the filter is not in use */
if (!ref_cnt) {
rc = qed_llh_remove_filter(p_hwfn, p_ptt, abs_ppfid, rc = qed_llh_remove_filter(p_hwfn, p_ptt, abs_ppfid,
filter_idx); filter_idx);
if (rc) if (rc)
...@@ -1253,12 +1253,12 @@ void qed_llh_remove_protocol_filter(struct qed_dev *cdev, ...@@ -1253,12 +1253,12 @@ void qed_llh_remove_protocol_filter(struct qed_dev *cdev,
if (rc) if (rc)
goto err; goto err;
/* Remove from the LLH in case the filter is not in use */
if (!ref_cnt) {
rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid); rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid);
if (rc) if (rc)
goto err; goto err;
/* Remove from the LLH in case the filter is not in use */
if (!ref_cnt) {
rc = qed_llh_remove_filter(p_hwfn, p_ptt, abs_ppfid, rc = qed_llh_remove_filter(p_hwfn, p_ptt, abs_ppfid,
filter_idx); filter_idx);
if (rc) if (rc)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment