Commit 8eeff89b authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] Print warning for common symbols in modules

From: Rusty Russell <rusty@rustcorp.com.au>

People still build modules wrong, particularly without -fno-common.  The
resulting modules don't load, but we should at least warn about it.
parent 2c941f77
......@@ -1003,6 +1003,8 @@ static int simplify_symbols(Elf_Shdr *sechdrs,
/* We compiled with -fno-common. These are not
supposed to happen. */
DEBUGP("Common symbol: %s\n", strtab + sym[i].st_name);
printk("%s: please compile with -fno-common\n",
mod->name);
ret = -ENOEXEC;
break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment