Commit 8f4ab7da authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Michael Ellerman

selftests/powerpc: Fix resource leaks

In check_all_cpu_dscr_defaults, opendir() opens the directory stream.
Add missing closedir() in the error path to release it.

In check_cpu_dscr_default, open() creates an open file descriptor.
Add missing close() in the error path to release it.

Fixes: ebd5858c ("selftests/powerpc: Add test for all DSCR sysfs interfaces")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221205084429.570654-1-linmq006@gmail.com
parent 6f3a81b6
...@@ -24,6 +24,7 @@ static int check_cpu_dscr_default(char *file, unsigned long val) ...@@ -24,6 +24,7 @@ static int check_cpu_dscr_default(char *file, unsigned long val)
rc = read(fd, buf, sizeof(buf)); rc = read(fd, buf, sizeof(buf));
if (rc == -1) { if (rc == -1) {
perror("read() failed"); perror("read() failed");
close(fd);
return 1; return 1;
} }
close(fd); close(fd);
...@@ -65,9 +66,11 @@ static int check_all_cpu_dscr_defaults(unsigned long val) ...@@ -65,9 +66,11 @@ static int check_all_cpu_dscr_defaults(unsigned long val)
if (access(file, F_OK)) if (access(file, F_OK))
continue; continue;
if (check_cpu_dscr_default(file, val)) if (check_cpu_dscr_default(file, val)) {
closedir(sysfs);
return 1; return 1;
} }
}
closedir(sysfs); closedir(sysfs);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment