Commit 93219a4f authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Alexandre Belloni

rtc: isl12022: Explicitly use __le16 type for ISL12022_REG_TEMP_L

We are reading 10-bit value in a 16-bit register in LE format.
Make this explicit by using __le16 type for it and corresponding
conversion function.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Link: https://lore.kernel.org/r/20230110140806.87432-3-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent f525b210
...@@ -19,6 +19,8 @@ ...@@ -19,6 +19,8 @@
#include <linux/regmap.h> #include <linux/regmap.h>
#include <linux/hwmon.h> #include <linux/hwmon.h>
#include <asm/byteorder.h>
/* ISL register offsets */ /* ISL register offsets */
#define ISL12022_REG_SC 0x00 #define ISL12022_REG_SC 0x00
#define ISL12022_REG_MN 0x01 #define ISL12022_REG_MN 0x01
...@@ -63,17 +65,16 @@ static umode_t isl12022_hwmon_is_visible(const void *data, ...@@ -63,17 +65,16 @@ static umode_t isl12022_hwmon_is_visible(const void *data,
static int isl12022_hwmon_read_temp(struct device *dev, long *mC) static int isl12022_hwmon_read_temp(struct device *dev, long *mC)
{ {
struct regmap *regmap = dev_get_drvdata(dev); struct regmap *regmap = dev_get_drvdata(dev);
u8 temp_buf[2];
int temp, ret; int temp, ret;
__le16 buf;
ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, &buf, sizeof(buf));
temp_buf, sizeof(temp_buf));
if (ret) if (ret)
return ret; return ret;
/* /*
* Temperature is represented as a 10-bit number, unit half-Kelvins. * Temperature is represented as a 10-bit number, unit half-Kelvins.
*/ */
temp = (temp_buf[1] << 8) | temp_buf[0]; temp = le16_to_cpu(buf);
temp *= 500; temp *= 500;
temp -= 273000; temp -= 273000;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment