Commit 936c9854 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Linus Walleij

dt-bindings: pinctrl: mt8195: Use real world values for drive-strength arguments

The original binding submission for MT8195 pinctrl described the
possible drive strength values in micro-amps in its description, but
then proceeded to list register values in its device tree binding
constraints.

However, the macros used with the Mediatek pinctrl bindings directly
specify the drive strength in micro-amps, instead of hardware register
values. The current driver implementation in Linux does convert the
value from micro-amps to hardware register values. This implementation
is also used with MT7622 and MT8183, which use real world values in
their device trees.

Given the above, it was likely an oversight to use the raw register
values in the binding. Correct the values in the binding. Also drop
the description since the binding combined with its parent,
pinctrl/pincfg.yaml, the binding is now self-describing.

Fixes: 7f766389 ("dt-bindings: pinctrl: mt8195: add pinctrl file and binding document")
Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Acked-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210726111941.1447057-1-wenst@chromium.orgSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 379e28b5
...@@ -80,10 +80,7 @@ patternProperties: ...@@ -80,10 +80,7 @@ patternProperties:
as macros in dt-bindings/pinctrl/<soc>-pinfunc.h directly. as macros in dt-bindings/pinctrl/<soc>-pinfunc.h directly.
drive-strength: drive-strength:
description: | enum: [2, 4, 6, 8, 10, 12, 14, 16]
It can support some arguments which is from 0 to 7. It can only support
2/4/6/8/10/12/14/16mA in mt8195.
enum: [0, 1, 2, 3, 4, 5, 6, 7]
bias-pull-down: true bias-pull-down: true
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment