Commit 94cff6e1 authored by Quinn Tran's avatar Quinn Tran Committed by Martin K. Petersen

scsi: qla2xxx: Remove unused argument from qlt_schedule_sess_for_deletion()

Immeadiate flag is not used for scheduling session deletion.
Remove it to simplfy session deletion code path.
Signed-off-by: default avatarQuinn Tran <quinn.tran@cavium.com>
Signed-off-by: default avatarHimanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6d674927
...@@ -887,7 +887,7 @@ void qla24xx_do_nack_work(struct scsi_qla_host *, struct qla_work_evt *); ...@@ -887,7 +887,7 @@ void qla24xx_do_nack_work(struct scsi_qla_host *, struct qla_work_evt *);
void qlt_plogi_ack_link(struct scsi_qla_host *, struct qlt_plogi_ack_t *, void qlt_plogi_ack_link(struct scsi_qla_host *, struct qlt_plogi_ack_t *,
struct fc_port *, enum qlt_plogi_link_t); struct fc_port *, enum qlt_plogi_link_t);
void qlt_plogi_ack_unref(struct scsi_qla_host *, struct qlt_plogi_ack_t *); void qlt_plogi_ack_unref(struct scsi_qla_host *, struct qlt_plogi_ack_t *);
extern void qlt_schedule_sess_for_deletion(struct fc_port *, bool); extern void qlt_schedule_sess_for_deletion(struct fc_port *);
extern void qlt_schedule_sess_for_deletion_lock(struct fc_port *); extern void qlt_schedule_sess_for_deletion_lock(struct fc_port *);
extern struct fc_port *qlt_find_sess_invalidate_other(scsi_qla_host_t *, extern struct fc_port *qlt_find_sess_invalidate_other(scsi_qla_host_t *,
uint64_t wwn, port_id_t port_id, uint16_t loop_id, struct fc_port **); uint64_t wwn, port_id_t port_id, uint16_t loop_id, struct fc_port **);
......
...@@ -353,7 +353,7 @@ void qla24xx_handle_adisc_event(scsi_qla_host_t *vha, struct event_arg *ea) ...@@ -353,7 +353,7 @@ void qla24xx_handle_adisc_event(scsi_qla_host_t *vha, struct event_arg *ea)
ql_dbg(ql_dbg_disc, vha, 0x2066, ql_dbg(ql_dbg_disc, vha, 0x2066,
"%s %8phC: adisc fail: post delete\n", "%s %8phC: adisc fail: post delete\n",
__func__, ea->fcport->port_name); __func__, ea->fcport->port_name);
qlt_schedule_sess_for_deletion(ea->fcport, 1); qlt_schedule_sess_for_deletion(ea->fcport);
return; return;
} }
...@@ -527,7 +527,7 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, ...@@ -527,7 +527,7 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha,
ql_dbg(ql_dbg_disc, vha, 0x20e3, ql_dbg(ql_dbg_disc, vha, 0x20e3,
"%s %d %8phC post del sess\n", "%s %d %8phC post del sess\n",
__func__, __LINE__, fcport->port_name); __func__, __LINE__, fcport->port_name);
qlt_schedule_sess_for_deletion(fcport, 1); qlt_schedule_sess_for_deletion(fcport);
return; return;
} }
...@@ -599,7 +599,7 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, ...@@ -599,7 +599,7 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha,
__func__, __LINE__, __func__, __LINE__,
conflict_fcport->port_name); conflict_fcport->port_name);
qlt_schedule_sess_for_deletion qlt_schedule_sess_for_deletion
(conflict_fcport, 1); (conflict_fcport);
} }
/* FW already picked this loop id for another fcport */ /* FW already picked this loop id for another fcport */
...@@ -1134,7 +1134,7 @@ static void qla_chk_n2n_b4_login(struct scsi_qla_host *vha, fc_port_t *fcport) ...@@ -1134,7 +1134,7 @@ static void qla_chk_n2n_b4_login(struct scsi_qla_host *vha, fc_port_t *fcport)
"%s %d %8phC post del sess - out of loopid\n", "%s %d %8phC post del sess - out of loopid\n",
__func__, __LINE__, fcport->port_name); __func__, __LINE__, fcport->port_name);
fcport->scan_state = 0; fcport->scan_state = 0;
qlt_schedule_sess_for_deletion(fcport, true); qlt_schedule_sess_for_deletion(fcport);
return; return;
} }
} }
...@@ -1780,7 +1780,7 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea) ...@@ -1780,7 +1780,7 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea)
set_bit(lid, vha->hw->loop_id_map); set_bit(lid, vha->hw->loop_id_map);
ea->fcport->loop_id = lid; ea->fcport->loop_id = lid;
ea->fcport->keep_nport_handle = 0; ea->fcport->keep_nport_handle = 0;
qlt_schedule_sess_for_deletion(ea->fcport, false); qlt_schedule_sess_for_deletion(ea->fcport);
} }
break; break;
} }
......
...@@ -1211,8 +1211,7 @@ static void qla24xx_chk_fcp_state(struct fc_port *sess) ...@@ -1211,8 +1211,7 @@ static void qla24xx_chk_fcp_state(struct fc_port *sess)
} }
/* ha->tgt.sess_lock supposed to be held on entry */ /* ha->tgt.sess_lock supposed to be held on entry */
void qlt_schedule_sess_for_deletion(struct fc_port *sess, void qlt_schedule_sess_for_deletion(struct fc_port *sess)
bool immediate)
{ {
struct qla_tgt *tgt = sess->tgt; struct qla_tgt *tgt = sess->tgt;
...@@ -1252,7 +1251,7 @@ void qlt_schedule_sess_for_deletion_lock(struct fc_port *sess) ...@@ -1252,7 +1251,7 @@ void qlt_schedule_sess_for_deletion_lock(struct fc_port *sess)
unsigned long flags; unsigned long flags;
struct qla_hw_data *ha = sess->vha->hw; struct qla_hw_data *ha = sess->vha->hw;
spin_lock_irqsave(&ha->tgt.sess_lock, flags); spin_lock_irqsave(&ha->tgt.sess_lock, flags);
qlt_schedule_sess_for_deletion(sess, 1); qlt_schedule_sess_for_deletion(sess);
spin_unlock_irqrestore(&ha->tgt.sess_lock, flags); spin_unlock_irqrestore(&ha->tgt.sess_lock, flags);
} }
...@@ -1264,7 +1263,7 @@ static void qlt_clear_tgt_db(struct qla_tgt *tgt) ...@@ -1264,7 +1263,7 @@ static void qlt_clear_tgt_db(struct qla_tgt *tgt)
list_for_each_entry(sess, &vha->vp_fcports, list) { list_for_each_entry(sess, &vha->vp_fcports, list) {
if (sess->se_sess) if (sess->se_sess)
qlt_schedule_sess_for_deletion(sess, 1); qlt_schedule_sess_for_deletion(sess);
} }
/* At this point tgt could be already dead */ /* At this point tgt could be already dead */
...@@ -1439,7 +1438,7 @@ qlt_fc_port_deleted(struct scsi_qla_host *vha, fc_port_t *fcport, int max_gen) ...@@ -1439,7 +1438,7 @@ qlt_fc_port_deleted(struct scsi_qla_host *vha, fc_port_t *fcport, int max_gen)
ql_dbg(ql_dbg_tgt_mgt, vha, 0xf008, "qla_tgt_fc_port_deleted %p", sess); ql_dbg(ql_dbg_tgt_mgt, vha, 0xf008, "qla_tgt_fc_port_deleted %p", sess);
sess->local = 1; sess->local = 1;
qlt_schedule_sess_for_deletion(sess, false); qlt_schedule_sess_for_deletion(sess);
spin_unlock_irqrestore(&vha->hw->tgt.sess_lock, flags); spin_unlock_irqrestore(&vha->hw->tgt.sess_lock, flags);
} }
...@@ -4522,7 +4521,7 @@ qlt_find_sess_invalidate_other(scsi_qla_host_t *vha, uint64_t wwn, ...@@ -4522,7 +4521,7 @@ qlt_find_sess_invalidate_other(scsi_qla_host_t *vha, uint64_t wwn,
* might have cleared it when requested this session * might have cleared it when requested this session
* deletion, so don't touch it * deletion, so don't touch it
*/ */
qlt_schedule_sess_for_deletion(other_sess, true); qlt_schedule_sess_for_deletion(other_sess);
} else { } else {
/* /*
* Another wwn used to have our s_id/loop_id * Another wwn used to have our s_id/loop_id
...@@ -4535,8 +4534,7 @@ qlt_find_sess_invalidate_other(scsi_qla_host_t *vha, uint64_t wwn, ...@@ -4535,8 +4534,7 @@ qlt_find_sess_invalidate_other(scsi_qla_host_t *vha, uint64_t wwn,
other_sess->keep_nport_handle = 1; other_sess->keep_nport_handle = 1;
if (other_sess->disc_state != DSC_DELETED) if (other_sess->disc_state != DSC_DELETED)
*conflict_sess = other_sess; *conflict_sess = other_sess;
qlt_schedule_sess_for_deletion(other_sess, qlt_schedule_sess_for_deletion(other_sess);
true);
} }
continue; continue;
} }
...@@ -4550,7 +4548,7 @@ qlt_find_sess_invalidate_other(scsi_qla_host_t *vha, uint64_t wwn, ...@@ -4550,7 +4548,7 @@ qlt_find_sess_invalidate_other(scsi_qla_host_t *vha, uint64_t wwn,
/* Same loop_id but different s_id /* Same loop_id but different s_id
* Ok to kill and logout */ * Ok to kill and logout */
qlt_schedule_sess_for_deletion(other_sess, true); qlt_schedule_sess_for_deletion(other_sess);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment