Commit 95b2a627 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Luis Henriques

ARM: shmobile: sh73a0 legacy: Set .control_parent for all irqpin instances

commit b0ddb319 upstream.

The sh73a0 INTC can't mask interrupts properly most likely due to a
hardware bug. Set the .control_parent flag to delegate masking to the
parent interrupt controller, like was already done for irqpin1.

Without this, accessing the three-axis digital accelerometer ADXL345
on kzm9g through /dev/input/event1 causes an interrupt storm, which
requires a power-cycle to recover from.

This was inspired by a patch for arch/arm/boot/dts/sh73a0.dtsi from
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Fixes: 341eb546 ("ARM: shmobile: INTC External IRQ pin driver on sh73a0")
Signed-off-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 5dfc47ac
...@@ -576,6 +576,7 @@ static struct platform_device ipmmu_device = { ...@@ -576,6 +576,7 @@ static struct platform_device ipmmu_device = {
static struct renesas_intc_irqpin_config irqpin0_platform_data = { static struct renesas_intc_irqpin_config irqpin0_platform_data = {
.irq_base = irq_pin(0), /* IRQ0 -> IRQ7 */ .irq_base = irq_pin(0), /* IRQ0 -> IRQ7 */
.control_parent = true,
}; };
static struct resource irqpin0_resources[] = { static struct resource irqpin0_resources[] = {
...@@ -637,6 +638,7 @@ static struct platform_device irqpin1_device = { ...@@ -637,6 +638,7 @@ static struct platform_device irqpin1_device = {
static struct renesas_intc_irqpin_config irqpin2_platform_data = { static struct renesas_intc_irqpin_config irqpin2_platform_data = {
.irq_base = irq_pin(16), /* IRQ16 -> IRQ23 */ .irq_base = irq_pin(16), /* IRQ16 -> IRQ23 */
.control_parent = true,
}; };
static struct resource irqpin2_resources[] = { static struct resource irqpin2_resources[] = {
...@@ -667,6 +669,7 @@ static struct platform_device irqpin2_device = { ...@@ -667,6 +669,7 @@ static struct platform_device irqpin2_device = {
static struct renesas_intc_irqpin_config irqpin3_platform_data = { static struct renesas_intc_irqpin_config irqpin3_platform_data = {
.irq_base = irq_pin(24), /* IRQ24 -> IRQ31 */ .irq_base = irq_pin(24), /* IRQ24 -> IRQ31 */
.control_parent = true,
}; };
static struct resource irqpin3_resources[] = { static struct resource irqpin3_resources[] = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment