Commit 95f7c05d authored by SeongJae Park's avatar SeongJae Park Committed by Andrew Morton

mm/damon/lru_sort: use monitoring attributes parameters generaotr macro

This commit makes DAMON_LRU_SORT to generate the module parameters for
DAMON monitoring attributes using the generator macro to simplify the code
and reduce duplicates.

Link: https://lkml.kernel.org/r/20220913174449.50645-11-sj@kernel.orgSigned-off-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent b3c28d88
...@@ -13,6 +13,8 @@ ...@@ -13,6 +13,8 @@
#include <linux/sched.h> #include <linux/sched.h>
#include <linux/workqueue.h> #include <linux/workqueue.h>
#include "modules-common.h"
#ifdef MODULE_PARAM_PREFIX #ifdef MODULE_PARAM_PREFIX
#undef MODULE_PARAM_PREFIX #undef MODULE_PARAM_PREFIX
#endif #endif
...@@ -128,52 +130,13 @@ static unsigned long wmarks_low __read_mostly = 50; ...@@ -128,52 +130,13 @@ static unsigned long wmarks_low __read_mostly = 50;
module_param(wmarks_low, ulong, 0600); module_param(wmarks_low, ulong, 0600);
static struct damon_attrs damon_lru_sort_mon_attrs = { static struct damon_attrs damon_lru_sort_mon_attrs = {
.sample_interval = 5000, .sample_interval = 5000, /* 5 ms */
.aggr_interval = 100000, .aggr_interval = 100000, /* 100 ms */
.ops_update_interval = 0, .ops_update_interval = 0,
.min_nr_regions = 10, .min_nr_regions = 10,
.max_nr_regions = 1000, .max_nr_regions = 1000,
}; };
DEFINE_DAMON_MODULES_MON_ATTRS_PARAMS(damon_lru_sort_mon_attrs);
/*
* Sampling interval for the monitoring in microseconds.
*
* The sampling interval of DAMON for the hot/cold memory monitoring. Please
* refer to the DAMON documentation for more detail. 5 ms by default.
*/
module_param_named(sample_interval, damon_lru_sort_mon_attrs.sample_interval,
ulong, 0600);
/*
* Aggregation interval for the monitoring in microseconds.
*
* The aggregation interval of DAMON for the hot/cold memory monitoring.
* Please refer to the DAMON documentation for more detail. 100 ms by default.
*/
module_param_named(aggr_interval, damon_lru_sort_mon_attrs.aggr_interval, ulong,
0600);
/*
* Minimum number of monitoring regions.
*
* The minimal number of monitoring regions of DAMON for the hot/cold memory
* monitoring. This can be used to set lower-bound of the monitoring quality.
* But, setting this too high could result in increased monitoring overhead.
* Please refer to the DAMON documentation for more detail. 10 by default.
*/
module_param_named(min_nr_regions, damon_lru_sort_mon_attrs.min_nr_regions,
ulong, 0600);
/*
* Maximum number of monitoring regions.
*
* The maximum number of monitoring regions of DAMON for the hot/cold memory
* monitoring. This can be used to set upper-bound of the monitoring overhead.
* However, setting this too low could result in bad monitoring quality.
* Please refer to the DAMON documentation for more detail. 1000 by default.
*/
module_param_named(max_nr_regions, damon_lru_sort_mon_attrs.max_nr_regions,
ulong, 0600);
/* /*
* Start of the target memory region in physical address. * Start of the target memory region in physical address.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment