Commit 96263d28 authored by Jim Cromie's avatar Jim Cromie Committed by Rusty Russell

init: add comments to keep initcall-names in sync with initcall levels

main.c has initcall_level_names[] for parse_args to print in debug messages,
add comments to keep them in sync with initcalls defined in init.h.

Also add "loadable" into comment re not using *_initcall macros in
modules, to disambiguate from kernel/params.c and other builtins.
Signed-off-by: default avatarJim Cromie <jim.cromie@gmail.com>
Acked-by: default avatarBorislav Petkov <borislav.petkov@amd.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent c777ad69
...@@ -191,6 +191,7 @@ extern bool initcall_debug; ...@@ -191,6 +191,7 @@ extern bool initcall_debug;
* initializes variables that couldn't be statically initialized. * initializes variables that couldn't be statically initialized.
* *
* This only exists for built-in code, not for modules. * This only exists for built-in code, not for modules.
* Keep main.c:initcall_level_names[] in sync.
*/ */
#define pure_initcall(fn) __define_initcall("0",fn,0) #define pure_initcall(fn) __define_initcall("0",fn,0)
...@@ -280,7 +281,7 @@ void __init parse_early_options(char *cmdline); ...@@ -280,7 +281,7 @@ void __init parse_early_options(char *cmdline);
#else /* MODULE */ #else /* MODULE */
/* Don't use these in modules, but some people do... */ /* Don't use these in loadable modules, but some people do... */
#define early_initcall(fn) module_init(fn) #define early_initcall(fn) module_init(fn)
#define core_initcall(fn) module_init(fn) #define core_initcall(fn) module_init(fn)
#define postcore_initcall(fn) module_init(fn) #define postcore_initcall(fn) module_init(fn)
......
...@@ -724,6 +724,7 @@ static initcall_t *initcall_levels[] __initdata = { ...@@ -724,6 +724,7 @@ static initcall_t *initcall_levels[] __initdata = {
__initcall_end, __initcall_end,
}; };
/* Keep these in sync with initcalls in include/linux/init.h */
static char *initcall_level_names[] __initdata = { static char *initcall_level_names[] __initdata = {
"early", "early",
"core", "core",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment